From: Cornelia Huck <cohuck@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: "christophe.de.dinechin@gmail.com"
<christophe.de.dinechin@gmail.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"mst@redhat.com" <mst@redhat.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"joonas.lahtinen@linux.intel.com"
<joonas.lahtinen@linux.intel.com>,
"heiko.carstens@de.ibm.com" <heiko.carstens@de.ibm.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"kwankhede@nvidia.com" <kwankhede@nvidia.com>,
"rob.miller@broadcom.com" <rob.miller@broadcom.com>,
"linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
"sebott@linux.ibm.com" <sebott@linux.ibm.com>,
"lulu@redhat.com" <lulu@redhat.com>,
"eperezma@redhat.com" <eperezma@redhat.com>,
"pasic@linux.ibm.com" <pasic@linux.ibm.com>,
"borntraeger@de.ibm.com" <borntraeger@de.ibm.com>,
haotian.wang@sifive.c
Subject: Re: [PATCH V3 4/7] mdev: introduce device specific ops
Date: Thu, 17 Oct 2019 10:45:16 +0200 [thread overview]
Message-ID: <20191017104516.52374ab6.cohuck@redhat.com> (raw)
In-Reply-To: <4886a6cd-a165-05b7-9f62-175076bbb2ba@redhat.com>
On Thu, 17 Oct 2019 16:30:43 +0800
Jason Wang <jasowang@redhat.com> wrote:
> On 2019/10/17 上午12:53, Alex Williamson wrote:
> >>> Yet another suggestion: have the class id derive from the function
> >>> you use to set up the ops.
> >>>
> >>> void mdev_set_vfio_ops(struct mdev_device *mdev, const struct
> >>> vfio_mdev_ops *vfio_ops) {
> >>> mdev->device_ops = vfio_ops;
> >>> mdev->class_id = MDEV_ID_VFIO;
> >>> }
> >>>
> >>> void mdev_set_virtio_ops(struct mdev_device *mdev, const struct
> >>> virtio_mdev_ops *virtio_ops) {
> >>> mdev->device_ops = virtio_ops;
> >>> mdev->class_id = MDEV_ID_VIRTIO;
> >>> }
> >>>
> >>> void mdev_set_vhost_ops(struct mdev_device *mdev, const struct
> >>> virtio_mdev_ops *virtio_ops) {
> >>> mdev->device_ops = virtio_ops;
> >>> mdev->class_id = MDEV_ID_VHOST;
> >>> }
> >>>
> >>> void mdev_set_vendor_ops(struct mdev_device *mdev) /* no ops */ {
> >>> mdev->class_id = MDEV_ID_VENDOR;
> >>> }
> > One further step towards making this hard to use incorrectly might be
> > to return an error if class_id is already set. Thanks,
> >
> > Alex
>
>
> I will add a BUG_ON() when class_id has already set.
Probably better a WARN_ON()?
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2019-10-17 8:45 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 8:15 [PATCH V3 0/7] mdev based hardware virtio offloading support Jason Wang
2019-10-11 8:15 ` [PATCH V3 1/7] mdev: class id support Jason Wang
2019-10-15 10:26 ` Cornelia Huck
2019-10-15 12:12 ` Jason Wang
2019-10-15 16:38 ` Alex Williamson
2019-10-16 4:38 ` Jason Wang
2019-10-16 4:57 ` Parav Pandit
2019-10-16 10:37 ` Jason Wang
2019-10-17 8:27 ` Jason Wang
2019-10-11 8:15 ` [PATCH V3 2/7] mdev: bus uevent support Jason Wang
2019-10-15 10:27 ` Cornelia Huck
2019-10-15 12:13 ` Jason Wang
2019-10-16 5:06 ` Parav Pandit
2019-10-11 8:15 ` [PATCH V3 3/7] modpost: add support for mdev class id Jason Wang
2019-10-11 8:15 ` [PATCH V3 4/7] mdev: introduce device specific ops Jason Wang
2019-10-15 10:41 ` Cornelia Huck
2019-10-15 12:17 ` Jason Wang
2019-10-15 17:26 ` Alex Williamson
2019-10-16 5:50 ` Parav Pandit
2019-10-16 8:52 ` Cornelia Huck
2019-10-16 15:31 ` Parav Pandit
2019-10-16 16:53 ` Alex Williamson
2019-10-16 20:48 ` Parav Pandit
2019-10-16 22:37 ` Alex Williamson
2019-10-17 16:29 ` Parav Pandit
2019-10-17 8:30 ` Jason Wang
2019-10-17 8:45 ` Cornelia Huck [this message]
2019-10-17 8:46 ` Jason Wang
2019-10-11 8:15 ` [PATCH V3 5/7] mdev: introduce virtio device and its device ops Jason Wang
2019-10-14 17:23 ` Stefan Hajnoczi
2019-10-15 3:27 ` Jason Wang
2019-10-11 8:15 ` [PATCH V3 6/7] virtio: introduce a mdev based transport Jason Wang
2019-10-14 17:39 ` Stefan Hajnoczi
2019-10-15 3:29 ` Jason Wang
2019-10-11 8:15 ` [PATCH V3 7/7] docs: sample driver to demonstrate how to implement virtio-mdev framework Jason Wang
2019-10-11 9:26 ` ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev4) Patchwork
2019-10-11 10:03 ` ✓ Fi.CI.BAT: success " Patchwork
2019-10-11 17:40 ` ✓ Fi.CI.IGT: " Patchwork
2019-10-14 17:49 ` [PATCH V3 0/7] mdev based hardware virtio offloading support Stefan Hajnoczi
2019-10-15 3:37 ` Jason Wang
2019-10-15 14:37 ` Stefan Hajnoczi
2019-10-17 1:42 ` Jason Wang
2019-10-17 9:43 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017104516.52374ab6.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=airlied@linux.ie \
--cc=borntraeger@de.ibm.com \
--cc=christophe.de.dinechin@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eperezma@redhat.com \
--cc=haotian.wang@sifive.c \
--cc=heiko.carstens@de.ibm.com \
--cc=jasowang@redhat.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-s390@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=rob.miller@broadcom.com \
--cc=sebott@linux.ibm.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox