public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"De Marchi, Lucas" <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/i915/tc: Implement the TC cold exit sequence
Date: Tue, 22 Oct 2019 18:52:28 +0300	[thread overview]
Message-ID: <20191022155228.GA8575@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <4f1c946b6e9123ea6fcbccf0d8c76eff0a2690a3.camel@intel.com>

On Tue, Oct 22, 2019 at 03:03:18AM +0300, Souza, Jose wrote:
> [...] 
> Makes sense, well the only doubt that I have is if getting
> POWER_DOMAIN_AUX_<port>_TBT will prevent TCCOLD for legacy and alt-
> mode, 

Why do we need to care about POWER_DOMAIN_AUX_<port>_TBT? It doesn't
affect the TCCOLD state and we shouldn't get it here.

> as at this point we still don't know if it is alt-mode, TBT or
> legacy(we know that is legacy but live status could be reporting
> something else tc_port_fixup_legacy_flag())

We enable the non-TBT AUX power and then drop after the mode is already
known and it's other than legacy.

--Imre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      reply	other threads:[~2019-10-22 15:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01  0:55 [PATCH] drm/i915/tc: Implement the TC cold exit sequence José Roberto de Souza
2019-10-01  1:39 ` ✗ Fi.CI.BAT: failure for " Patchwork
2019-10-01  7:56 ` ✓ Fi.CI.BAT: success for drm/i915/tc: Implement the TC cold exit sequence (rev2) Patchwork
2019-10-01 10:04 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-10-03 14:50 ` [PATCH] drm/i915/tc: Implement the TC cold exit sequence Imre Deak
2019-10-18 23:59   ` Souza, Jose
2019-10-19 10:49     ` Imre Deak
2019-10-22  0:03       ` Souza, Jose
2019-10-22 15:52         ` Imre Deak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191022155228.GA8575@ideak-desk.fi.intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    --cc=lucas.demarchi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox