From: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 07/33] drm/i915/gt: Mark up ips_mchdev pointer access
Date: Thu, 12 Dec 2019 08:39:55 -0800 [thread overview]
Message-ID: <20191212163955.GB28505@intel.com> (raw)
In-Reply-To: <20191212140459.1307617-7-chris@chris-wilson.co.uk>
On 19/12/12 02:04, Chris Wilson wrote:
> drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: error: incompatible types in comparison expression (different address spaces):
> drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: struct drm_i915_private [noderef] <asn:4> *
> drivers/gpu/drm/i915/gt/intel_rps.c:1726:24: struct drm_i915_private *
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> drivers/gpu/drm/i915/gt/intel_rps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index fd01e4100fc1..106c9fce9d6c 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -1723,7 +1723,7 @@ void intel_rps_driver_register(struct intel_rps *rps)
>
> void intel_rps_driver_unregister(struct intel_rps *rps)
> {
> - if (ips_mchdev == rps_to_i915(rps))
> + if (rcu_access_pointer(ips_mchdev) == rps_to_i915(rps))
> rcu_assign_pointer(ips_mchdev, NULL);
> }
Right way to access rcu pointer.
Reviewed-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@intel.com>
>
> --
> 2.24.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-12 16:39 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 14:04 [Intel-gfx] [PATCH 01/33] drm/i915: Use EAGAIN for trylock failures Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 02/33] drm/i915: Eliminate the trylock for awaiting an earlier request Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 03/33] drm/i915/gt: Eliminate the trylock for reading a timeline's hwsp Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 04/33] drm/i915/uc: Ignore maybe-unused debug-only i915 local Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 05/33] drm/i915/gem: Prepare gen7 cmdparser for async execution Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 06/33] drm/i915/gem: Asynchronous cmdparser Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 07/33] drm/i915/gt: Mark up ips_mchdev pointer access Chris Wilson
2019-12-12 16:39 ` Venkata Sandeep Dhanalakota [this message]
2019-12-12 14:04 ` [Intel-gfx] [PATCH 08/33] drm/i915/gt: Mark context->state vma as active while pinned Chris Wilson
2019-12-12 19:55 ` Lionel Landwerlin
2019-12-12 21:35 ` Lionel Landwerlin
2019-12-12 21:46 ` Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 09/33] drm/i915/gt: Mark ring->vma " Chris Wilson
2019-12-12 19:55 ` Lionel Landwerlin
2019-12-12 14:04 ` [Intel-gfx] [PATCH 10/33] drm/i915/selftests: Disable heartbeats around long queues Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 11/33] drm/i915/selftests: Impose a timeout for request submission Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 12/33] drm/i915/gt: Remove direct invocation of breadcrumb signaling Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 13/33] drm/i915: Tweak scheduler's kick_submission() Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 14/33] drm/i915: Flush idle barriers when waiting Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 15/33] drm/i915: Allow userspace to specify ringsize on construction Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 16/33] drm/i915/gem: Honour O_NONBLOCK before throttling execbuf submissions Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 17/33] drm/i915/gt: Teach veng to defer the context allocation Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 18/33] drm/i915: Drop GEM context as a direct link from i915_request Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 19/33] drm/i915: Push the use-semaphore marker onto the intel_context Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 20/33] drm/i915: Remove i915->kernel_context Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 21/33] drm/i915: Move i915_gem_init_contexts() earlier Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 22/33] drm/i915/uc: Use an internal buffer for firmware images Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 23/33] drm/i915/gt: Pull GT initialisation under intel_gt_init() Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 24/33] drm/i915/gt: Pull intel_gt_init_hw() into intel_gt_resume() Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 25/33] drm/i915/gt: Merge engine init/setup loops Chris Wilson
2019-12-12 14:04 ` [Intel-gfx] [PATCH 26/33] drm/i915/gt: Expose engine properties via sysfs Chris Wilson
2020-01-22 21:13 ` [Intel-gfx] [26/33] " Steve Carbonari
2019-12-12 14:04 ` [Intel-gfx] [PATCH 27/33] drm/i915/gt: Expose engine->mmio_base " Chris Wilson
2020-01-22 21:18 ` [Intel-gfx] [27/33] " Steve Carbonari
2019-12-12 14:04 ` [Intel-gfx] [PATCH 28/33] drm/i915/gt: Expose timeslice duration to sysfs Chris Wilson
2020-01-22 21:25 ` [Intel-gfx] [28/33] " Steve Carbonari
2019-12-12 14:04 ` [Intel-gfx] [PATCH 29/33] drm/i915/gt: Expose busywait " Chris Wilson
2020-01-22 21:29 ` [Intel-gfx] [29/33] " Steve Carbonari
2019-12-12 14:04 ` [Intel-gfx] [PATCH 30/33] drm/i915/gt: Expose reset stop timeout via sysfs Chris Wilson
2020-01-22 21:34 ` [Intel-gfx] [30/33] " Steve Carbonari
2019-12-12 14:04 ` [Intel-gfx] [PATCH 31/33] drm/i915/gt: Expose preempt reset " Chris Wilson
2020-01-22 21:36 ` [Intel-gfx] [31/33] " Steve Carbonari
2019-12-12 14:04 ` [Intel-gfx] [PATCH 32/33] drm/i915/gt: Expose heartbeat interval " Chris Wilson
2020-01-22 21:38 ` [Intel-gfx] [32/33] " Steve Carbonari
2019-12-12 14:04 ` [Intel-gfx] [PATCH 33/33] HAX: Use aliasing-ppgtt for gen7 Chris Wilson
2019-12-12 18:09 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/33] drm/i915: Use EAGAIN for trylock failures Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212163955.GB28505@intel.com \
--to=venkata.s.dhanalakota@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox