From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gem: Serialise object before changing cache-level
Date: Mon, 16 Dec 2019 12:56:50 +0200 [thread overview]
Message-ID: <20191216105650.GA2571@intel.intel> (raw)
In-Reply-To: <20191213223140.1830738-1-chris@chris-wilson.co.uk>
Hi Chris,
On Fri, Dec 13, 2019 at 10:31:40PM +0000, Chris Wilson wrote:
> Wait for the object to be idle before changing its cache-level and
> unbinding. This was dropped as supposedly superfluous from commit
> 8b1c78e06e61 ("drm/i915: Avoid calling i915_gem_object_unbind holding
> object lock"), but it turns out to prevent some cache dirt escaping.
> Smells like papering over a race...
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/820
> Fixes: 8b1c78e06e61 ("drm/i915: Avoid calling i915_gem_object_unbind holding object lock")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Andi Shyti <andi.shyti@intel.com>
Acked-by: Andi Shyti <andi.shyti@intel.com>
Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2019-12-16 10:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 22:31 [Intel-gfx] [PATCH] drm/i915/gem: Serialise object before changing cache-level Chris Wilson
2019-12-14 1:38 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-12-14 2:21 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-15 1:12 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2019-12-16 10:56 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216105650.GA2571@intel.intel \
--to=andi.shyti@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox