From: Manasi Navare <manasi.d.navare@intel.com>
To: "Manna, Animesh" <animesh.manna@intel.com>
Cc: Harry Wentland <harry.wentland@amd.com>,
jani.nikula@intel.com, nidhi1.gupta@intel.com,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Harry Wentland <hwentlan@amd.com>
Subject: Re: [Intel-gfx] [PATCH v2 2/9] drm/amd/display: Fix compilation issue.
Date: Wed, 18 Dec 2019 15:53:24 -0800 [thread overview]
Message-ID: <20191218235324.GI12192@intel.com> (raw)
In-Reply-To: <0a2bc02e-e3fa-b177-0c3b-fe7c323337a0@intel.com>
On Wed, Dec 18, 2019 at 09:43:49PM +0530, Manna, Animesh wrote:
>
> On 18-12-2019 21:12, Harry Wentland wrote:
> >On 2019-12-18 10:13 a.m., Animesh Manna wrote:
> >>[Why]:
> >>Aligh with DP spec wanted to follow same naming convention.
> >>
> >>[How]:
> >>Changed the macro name of the dpcd address used for getting requested
> >>test-pattern.
> >>
> >Please roll this into your patch that renames the definition. All
> >patches should compile on their own.
>
>
> Thanks Harry for review, wanted to follow similar commit-description format
> followed in amd-driver compare to i915 and created a separate patch. Maybe
> is it good idea to change the patch sequence and make it as first patch.
>
> Regards,
> Animesh
Like Harry said, all these changes should happen in the same patch that renames the DP_TEST_PHY_PATTERN
which is patch 1/9 because like you see the build still fails now since patch 1 doesnt compile.
So the idea would be in patch 1 - rename, make changes in AMD and existing place where it gets used
Patch 2 - get/set PHY test paarams that use this renamed value
Manasi
>
> >
> >Thanks,
> >Harry
> >
> >>Cc: Harry Wentland <harry.wentland@amd.com>
> >>Cc: Alex Deucher <alexander.deucher@amd.com>
> >>Signed-off-by: Animesh Manna <animesh.manna@intel.com>
> >>---
> >> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> >>index 42aa889fd0f5..1a6109be2fce 100644
> >>--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> >>+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> >>@@ -2491,7 +2491,7 @@ static void dp_test_send_phy_test_pattern(struct dc_link *link)
> >> /* get phy test pattern and pattern parameters from DP receiver */
> >> core_link_read_dpcd(
> >> link,
> >>- DP_TEST_PHY_PATTERN,
> >>+ DP_PHY_TEST_PATTERN,
> >> &dpcd_test_pattern.raw,
> >> sizeof(dpcd_test_pattern));
> >> core_link_read_dpcd(
> >>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-12-18 23:51 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 15:13 [Intel-gfx] [PATCH v2 0/9] DP Phy compliance auto test Animesh Manna
2019-12-18 15:13 ` [Intel-gfx] [PATCH v2 1/9] drm/dp: get/set phy compliance pattern Animesh Manna
2019-12-18 15:13 ` [Intel-gfx] [PATCH v2 2/9] drm/amd/display: Fix compilation issue Animesh Manna
2019-12-18 15:42 ` Harry Wentland
2019-12-18 16:13 ` Manna, Animesh
2019-12-18 16:22 ` Harry Wentland
2019-12-18 23:53 ` Manasi Navare [this message]
2019-12-19 13:36 ` Manna, Animesh
2019-12-23 17:03 ` [Intel-gfx] [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec Animesh Manna
2019-12-23 17:03 ` [Intel-gfx] [PATCH v3 2/9] drm/dp: get/set phy compliance pattern Animesh Manna
2019-12-23 19:53 ` Harry Wentland
2019-12-30 16:05 ` Manna, Animesh
2019-12-30 16:11 ` Harry Wentland
2019-12-30 16:30 ` Manna, Animesh
2019-12-23 19:53 ` [Intel-gfx] [PATCH v3 1/9] drm/amd/display: Align macro name as per DP spec Harry Wentland
2019-12-18 15:13 ` [Intel-gfx] [PATCH v2 3/9] drm/i915/dp: Move vswing/pre-emphasis adjustment calculation Animesh Manna
2019-12-19 10:51 ` Jani Nikula
2019-12-19 13:27 ` Manna, Animesh
2019-12-19 12:33 ` Ville Syrjälä
2019-12-19 13:31 ` Manna, Animesh
2019-12-23 16:45 ` [Intel-gfx] [PATCH v3 " Animesh Manna
2019-12-18 15:13 ` [Intel-gfx] [PATCH v2 4/9] drm/i915/dp: Preparation for DP phy compliance auto test Animesh Manna
2019-12-18 15:13 ` [Intel-gfx] [PATCH v2 5/9] drm/i915/dsb: Send uevent to testapp Animesh Manna
2019-12-18 15:13 ` [Intel-gfx] [PATCH v2 6/9] drm/i915/dp: Add debugfs entry for DP phy compliance Animesh Manna
2019-12-18 15:13 ` [Intel-gfx] [PATCH v2 7/9] drm/i915/dp: Register definition for DP compliance register Animesh Manna
2019-12-18 15:13 ` [Intel-gfx] [PATCH v2 8/9] drm/i915/dp: Update the pattern as per request Animesh Manna
2019-12-18 15:13 ` [Intel-gfx] [PATCH v2 9/9] drm/i915/dp: [FIXME] Program vswing, pre-emphasis, test-pattern Animesh Manna
2019-12-18 18:42 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DP Phy compliance auto test Patchwork
2019-12-18 18:44 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2019-12-18 19:11 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2019-12-20 4:31 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2019-12-23 19:33 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for DP Phy compliance auto test (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191218235324.GI12192@intel.com \
--to=manasi.d.navare@intel.com \
--cc=alexander.deucher@amd.com \
--cc=animesh.manna@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=hwentlan@amd.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=nidhi1.gupta@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox