From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Matt Atwood <matthew.s.atwood@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl
Date: Tue, 28 Jan 2020 19:05:38 +0200 [thread overview]
Message-ID: <20200128170538.GN13686@intel.com> (raw)
In-Reply-To: <20200117091627.1697-1-matthew.s.atwood@intel.com>
On Fri, Jan 17, 2020 at 04:16:28AM -0500, Matt Atwood wrote:
> On Tiger Lake we do not support source keying in the pixel formats P010,
> P012, P016.
>
> Bspec: 52890
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Matt Atwood <matthew.s.atwood@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_sprite.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> index fca77ec1e0dd..67176524e60f 100644
> --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> @@ -2049,6 +2049,19 @@ static int skl_plane_check_fb(const struct intel_crtc_state *crtc_state,
> unsigned int rotation = plane_state->hw.rotation;
> struct drm_format_name_buf format_name;
>
> + /* Wa_1606054188;tgl
> + *
> + * TODO: Add format RGB64i when implemented
> + *
> + */
> + if (IS_GEN(dev_priv, 12) &&
> + (plane_state->ckey.flags & I915_SET_COLORKEY_SOURCE))
> + if (fb->format->format & (DRM_FORMAT_P010 | DRM_FORMAT_P012
> + | DRM_FORMAT_P016)) {
if (a && b && c)
Needless parens.
Continuing | should go to the end. Also alignment is borked.
> + DRM_DEBUG_KMS("GEN12 does not support source color key planes in formats P01x\n");
Feels a bit overly verbose:
"Source color keying not supported with P01x formats\n"
> + return -EINVAL;
> + }
> +
> if (!fb)
> return 0;
What Manasi said. In fact pls move the thing to the end of the function
because I have more color key checks queued up in a branch and IIRC
I put them to the very end of the function.
>
> --
> 2.21.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-01-28 17:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 9:16 [Intel-gfx] [PATCH] drm/i915/tgl: Add Wa_1606054188;tgl Matt Atwood
2020-01-17 1:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-01-17 1:00 ` [Intel-gfx] ✗ Fi.CI.BUILD: warning " Patchwork
2020-01-20 8:01 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2020-01-27 22:42 ` [Intel-gfx] [PATCH] " Manasi Navare
2020-01-28 17:05 ` Ville Syrjälä [this message]
2020-01-28 17:30 ` Ville Syrjälä
2020-01-28 20:28 ` Manasi Navare
2020-01-29 11:35 ` Ville Syrjälä
2020-01-28 20:53 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200128170538.GN13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.s.atwood@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox