From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge
Date: Tue, 4 Feb 2020 11:06:36 +0200 [thread overview]
Message-ID: <20200204090636.GA1670@intel.intel> (raw)
In-Reply-To: <20200203202110.670209-1-chris@chris-wilson.co.uk>
Hi Chris,
> The current rc6 threshold is larger than the evaluation interval on
> Ivybridge; it never enters rc6. Remove the special casing so it behaves
> like the other gen6/gen7, and we see rc6 residencies before we manually
> park the system.
>
> Closes: https://gitlab.freedesktop.org/drm/intel/issues/1114
> Testcase: igt/i915_pm_rc6_residency/rc6-idle #ivb
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Andi Shyti <andi.shyti@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> index 01a99fdbb3c4..682f598f7042 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> @@ -226,10 +226,7 @@ static void gen6_rc6_enable(struct intel_rc6 *rc6)
>
> set(uncore, GEN6_RC_SLEEP, 0);
> set(uncore, GEN6_RC1e_THRESHOLD, 1000);
> - if (IS_IVYBRIDGE(i915))
> - set(uncore, GEN6_RC6_THRESHOLD, 125000);
> - else
> - set(uncore, GEN6_RC6_THRESHOLD, 50000);
> + set(uncore, GEN6_RC6_THRESHOLD, 50000);
why was is set like this in a first place?
Thanks,
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-04 9:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-03 20:21 [Intel-gfx] [PATCH] drm/i915/gt: Fix rc6 on Ivybridge Chris Wilson
2020-02-04 9:06 ` Andi Shyti [this message]
2020-02-04 9:09 ` Chris Wilson
2020-02-04 9:58 ` Andi Shyti
2020-02-04 20:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200204090636.GA1670@intel.intel \
--to=andi.shyti@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox