From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl: Remove require_force_probe protection
Date: Tue, 18 Feb 2020 17:01:06 -0800 [thread overview]
Message-ID: <20200219010106.GE587076@intel.com> (raw)
In-Reply-To: <20200218230822.66801-1-jose.souza@intel.com>
On Tue, Feb 18, 2020 at 03:08:22PM -0800, José Roberto de Souza wrote:
> We have a few TGL machines in our CI and it is mostly green with
> failures in tests that will not impact future Linux installations.
> Also there is no warnings, errors, flickering or any visual defects
> while doing ordinary tasks like browsing and editing documents in a
> dual monitor setup.
>
> As a reminder i915.require_force_probe was created to protect
> future Linux installation's iso images that might contain a
> kernel from the enabling time of the new platform. Without this
> protection most of linux installation was recommending
> nomodeset option during installation that was getting stick
> there after installation.
>
> Reference: https://intel-gfx-ci.01.org/tree/drm-tip/fi-tgl-u.html
> Reference: https://intel-gfx-ci.01.org/tree/drm-tip/shard-tglb.html
> Cc: James Ausmus <james.ausmus@intel.com>
> Cc: Jani Saarinen <jani.saarinen@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 24b1f0ce8743..2146b9a865ba 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -822,7 +822,6 @@ static const struct intel_device_info tgl_info = {
> GEN12_FEATURES,
> PLATFORM(INTEL_TIGERLAKE),
> .pipe_mask = BIT(PIPE_A) | BIT(PIPE_B) | BIT(PIPE_C) | BIT(PIPE_D),
> - .require_force_probe = 1,
> .display.has_modular_fia = 1,
> .engine_mask =
> BIT(RCS0) | BIT(BCS0) | BIT(VECS0) | BIT(VCS0) | BIT(VCS2),
> --
> 2.25.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-19 0:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 23:08 [Intel-gfx] [PATCH] drm/i915/tgl: Remove require_force_probe protection José Roberto de Souza
2020-02-19 1:01 ` Rodrigo Vivi [this message]
2020-02-19 5:06 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-02-20 19:03 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-13 21:31 ` Souza, Jose
2020-03-03 20:26 ` [Intel-gfx] [PATCH] " Lucas De Marchi
2020-03-03 20:39 ` Rodrigo Vivi
2020-03-03 21:29 ` Souza, Jose
2020-03-03 21:41 ` Lucas De Marchi
2020-03-04 9:11 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219010106.GE587076@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox