From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dram: hide the dram structs better
Date: Thu, 27 Feb 2020 18:42:02 +0200 [thread overview]
Message-ID: <20200227164202.GV13686@intel.com> (raw)
In-Reply-To: <20200227145359.17543-1-jani.nikula@intel.com>
On Thu, Feb 27, 2020 at 04:53:59PM +0200, Jani Nikula wrote:
> Finish the job started in d28ae3b28187 ("drm/i915: split out
> intel_dram.[ch] from i915_drv.c") by moving struct dram_dimm_info and
> dram_channel_info inside intel_dram.c, the only user of the structs.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_drv.h | 10 ----------
> drivers/gpu/drm/i915/intel_dram.c | 10 ++++++++++
> 2 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index ea13fc0b409b..c5a06f864123 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -1274,16 +1274,6 @@ struct drm_i915_private {
> */
> };
>
> -struct dram_dimm_info {
> - u8 size, width, ranks;
> -};
> -
> -struct dram_channel_info {
> - struct dram_dimm_info dimm_l, dimm_s;
> - u8 ranks;
> - bool is_16gb_dimm;
> -};
> -
> static inline struct drm_i915_private *to_i915(const struct drm_device *dev)
> {
> return container_of(dev, struct drm_i915_private, drm);
> diff --git a/drivers/gpu/drm/i915/intel_dram.c b/drivers/gpu/drm/i915/intel_dram.c
> index 9bb9dd724d3f..6b922efb1d7c 100644
> --- a/drivers/gpu/drm/i915/intel_dram.c
> +++ b/drivers/gpu/drm/i915/intel_dram.c
> @@ -6,6 +6,16 @@
> #include "i915_drv.h"
> #include "intel_dram.h"
>
> +struct dram_dimm_info {
> + u8 size, width, ranks;
> +};
> +
> +struct dram_channel_info {
> + struct dram_dimm_info dimm_l, dimm_s;
> + u8 ranks;
> + bool is_16gb_dimm;
> +};
> +
> #define DRAM_TYPE_STR(type) [INTEL_DRAM_ ## type] = #type
>
> static const char *intel_dram_type_str(enum intel_dram_type type)
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-02-27 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 14:53 [Intel-gfx] [PATCH] drm/i915/dram: hide the dram structs better Jani Nikula
2020-02-27 16:42 ` Ville Syrjälä [this message]
2020-03-02 11:50 ` Jani Nikula
2020-02-27 18:27 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-02-27 18:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-02-28 22:58 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227164202.GV13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox