From: Ramalingam C <ramalingam.c@intel.com>
To: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/hdcp: Return 0 on config_stream_type() +ve return
Date: Mon, 2 Mar 2020 19:38:14 +0530 [thread overview]
Message-ID: <20200302140814.GB18015@intel.com> (raw)
In-Reply-To: <20200220123217.23635-3-anshuman.gupta@intel.com>
On 2020-02-20 at 18:02:17 +0530, Anshuman Gupta wrote:
> As DP shim's config_stream_type returns size of message
> to be written in case of success therefore on
> config_stream_type success return a zero success
> value in order to succeed the HDCP auth.
>
> CC: Ramalingam C <ramalingam.c@intel.com>
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hdcp.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
> index 75f60ca282fc..464ef7ba4db4 100644
> --- a/drivers/gpu/drm/i915/display/intel_hdcp.c
> +++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
> @@ -1538,7 +1538,9 @@ static int hdcp2_authenticate_sink(struct intel_connector *connector)
> ret = shim->config_stream_type(intel_dig_port,
> hdcp->is_repeater,
> hdcp->content_type);
> - if (ret < 0)
> + if (ret >= 0)
> + ret = 0;
> + else
Anshuman, could we convert the return value of
intel_dp_hdcp2_config_stream_type to return the 0 or -ve, as the
functions is for configuring thr stream_type? Returning the bytes
written is not useful for the caller.
-Ram.
> return ret;
> }
>
> --
> 2.24.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-02 14:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 12:32 [Intel-gfx] [PATCH v3 0/2] HDCP 2.2 Comp fixes Anshuman Gupta
2020-02-20 12:32 ` [Intel-gfx] [PATCH v3 1/2] drm/i915/hdcp: Mandate (seq_num_V==0) at first RecvId msg Anshuman Gupta
2020-02-20 12:32 ` [Intel-gfx] [PATCH v3 2/2] drm/i915/hdcp: Return 0 on config_stream_type() +ve return Anshuman Gupta
2020-03-02 14:08 ` Ramalingam C [this message]
2020-03-03 5:24 ` [Intel-gfx] [PATCH v4 2/2] drm/i915/hdcp: Fix config_stream_type() ret value Anshuman Gupta
2020-03-03 5:43 ` Ramalingam C
2020-03-03 5:52 ` Anshuman Gupta
2020-03-03 6:25 ` Ramalingam C
2020-03-03 7:38 ` Anshuman Gupta
2020-03-03 10:20 ` Ramalingam C
2020-03-03 12:45 ` Anshuman Gupta
2020-02-20 20:25 ` [Intel-gfx] ✓ Fi.CI.BAT: success for HDCP 2.2 Comp fixes Patchwork
2020-02-23 5:35 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-03 6:05 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for HDCP 2.2 Comp fixes (rev2) Patchwork
2020-03-03 6:16 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-03 8:15 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for HDCP 2.2 Comp fixes (rev3) Patchwork
2020-03-03 8:26 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-03-03 16:53 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-04 1:43 ` [Intel-gfx] [PATCH v3 0/2] HDCP 2.2 Comp fixes Ramalingam C
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200302140814.GB18015@intel.com \
--to=ramalingam.c@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox