Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: intel-gfx@lists.freedesktop.org, kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH v4 1/3] drm/i915/perf: remove generated code
Date: Thu, 12 Mar 2020 16:51:24 +0300	[thread overview]
Message-ID: <20200312135124.GK11561@kadam> (raw)
In-Reply-To: <20200306100557.2077450-1-lionel.g.landwerlin@intel.com>

Hi Lionel,

Thank you for the patch! Perhaps something to improve:

url:    https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-perf-remove-generated-code/20200307-024544
base:   git://anongit.freedesktop.org/drm-intel for-linux-next

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/i915/selftests/i915_perf.c:26 alloc_empty_config() warn: returning -1 instead of -ENOMEM is sloppy
drivers/gpu/drm/i915/selftests/i915_perf.c:43 alloc_empty_config() warn: inconsistent returns 'perf->metrics_lock'.

# https://github.com/0day-ci/linux/commit/9da4da9daea4fec31c06906294a6e64e9bd19783
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 9da4da9daea4fec31c06906294a6e64e9bd19783
vim +26 drivers/gpu/drm/i915/selftests/i915_perf.c

9da4da9daea4fe Lionel Landwerlin 2020-03-06  19  static int
9da4da9daea4fe Lionel Landwerlin 2020-03-06  20  alloc_empty_config(struct i915_perf *perf)
9da4da9daea4fe Lionel Landwerlin 2020-03-06  21  {
9da4da9daea4fe Lionel Landwerlin 2020-03-06  22  	struct i915_oa_config *oa_config;
9da4da9daea4fe Lionel Landwerlin 2020-03-06  23  
9da4da9daea4fe Lionel Landwerlin 2020-03-06  24  	oa_config = kzalloc(sizeof(*oa_config), GFP_KERNEL);
9da4da9daea4fe Lionel Landwerlin 2020-03-06  25  	if (!oa_config)
9da4da9daea4fe Lionel Landwerlin 2020-03-06 @26  		return -1;

return -ENOMEM

9da4da9daea4fe Lionel Landwerlin 2020-03-06  27  
9da4da9daea4fe Lionel Landwerlin 2020-03-06  28  	oa_config->perf = perf;
9da4da9daea4fe Lionel Landwerlin 2020-03-06  29  	kref_init(&oa_config->ref);
9da4da9daea4fe Lionel Landwerlin 2020-03-06  30  
9da4da9daea4fe Lionel Landwerlin 2020-03-06  31  	strlcpy(oa_config->uuid, TEST_OA_CONFIG_UUID, sizeof(oa_config->uuid));
9da4da9daea4fe Lionel Landwerlin 2020-03-06  32  
9da4da9daea4fe Lionel Landwerlin 2020-03-06  33  	mutex_lock(&perf->metrics_lock);
9da4da9daea4fe Lionel Landwerlin 2020-03-06  34  
9da4da9daea4fe Lionel Landwerlin 2020-03-06  35  	oa_config->id = idr_alloc(&perf->metrics_idr, oa_config, 2, 0, GFP_KERNEL);
9da4da9daea4fe Lionel Landwerlin 2020-03-06  36  	if (oa_config->id < 0)  {
9da4da9daea4fe Lionel Landwerlin 2020-03-06  37  		i915_oa_config_put(oa_config);

unlock

9da4da9daea4fe Lionel Landwerlin 2020-03-06  38  		return -1;

return oa_config->id;

9da4da9daea4fe Lionel Landwerlin 2020-03-06  39  	}
9da4da9daea4fe Lionel Landwerlin 2020-03-06  40  
9da4da9daea4fe Lionel Landwerlin 2020-03-06  41  	mutex_unlock(&perf->metrics_lock);
9da4da9daea4fe Lionel Landwerlin 2020-03-06  42  
9da4da9daea4fe Lionel Landwerlin 2020-03-06 @43  	return 0;
9da4da9daea4fe Lionel Landwerlin 2020-03-06  44  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

      parent reply	other threads:[~2020-03-12 13:51 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-06 10:05 [Intel-gfx] [PATCH v4 1/3] drm/i915/perf: remove generated code Lionel Landwerlin
2020-03-06 10:05 ` [Intel-gfx] [PATCH v4 2/3] drm/i915/perf: remove redundant power configuration register override Lionel Landwerlin
2020-03-12 17:46   ` Tvrtko Ursulin
2020-03-06 10:05 ` [Intel-gfx] [PATCH v4 3/3] drm/i915/perf: introduce global sseu pinning Lionel Landwerlin
2020-03-12 18:19   ` Tvrtko Ursulin
2020-03-12 22:41     ` Tvrtko Ursulin
2020-03-13 13:40       ` Lionel Landwerlin
2020-03-13 13:34     ` Lionel Landwerlin
2020-03-06 16:34 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4,1/3] drm/i915/perf: remove generated code Patchwork
2020-03-06 16:51 ` [Intel-gfx] ✗ Fi.CI.DOCS: " Patchwork
2020-03-06 17:19 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-03-12 13:51 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200312135124.GK11561@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    --cc=lionel.g.landwerlin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox