From: Anshuman Gupta <anshuman.gupta@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: jani.nikula@intel.com, ankit.k.nautiyal@intel.com
Subject: [Intel-gfx] [PATCH 2/2] drm/i915: Add i915_lpsp_info debugfs
Date: Thu, 12 Mar 2020 19:37:02 +0530 [thread overview]
Message-ID: <20200312140702.14028-3-anshuman.gupta@intel.com> (raw)
In-Reply-To: <20200312140702.14028-1-anshuman.gupta@intel.com>
New i915_pm_lpsp igt solution approach relies on connector specific
debugfs attribute i915_lpsp_info, it exposes whether an output is
capable of driving lpsp and exposes lpsp enablement info.
Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
---
.../drm/i915/display/intel_display_debugfs.c | 65 +++++++++++++++++++
.../drm/i915/display/intel_display_power.h | 2 +
2 files changed, 67 insertions(+)
diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
index 1e6eb7f2f72d..16ee04368cc1 100644
--- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
+++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
@@ -9,6 +9,7 @@
#include "i915_debugfs.h"
#include "intel_csr.h"
#include "intel_display_debugfs.h"
+#include "intel_display_power.h"
#include "intel_display_types.h"
#include "intel_dp.h"
#include "intel_fbc.h"
@@ -611,6 +612,56 @@ static void intel_hdcp_info(struct seq_file *m,
seq_puts(m, "\n");
}
+static bool intel_have_embedded_panel(struct drm_connector *connector)
+{
+ return connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
+ connector->connector_type == DRM_MODE_CONNECTOR_eDP;
+}
+
+static bool intel_have_hdmi_panel(struct drm_connector *connector)
+{
+ return connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
+ connector->connector_type == DRM_MODE_CONNECTOR_HDMIB;
+}
+
+static void
+intel_lpsp_capable_info(struct seq_file *m, struct drm_connector *connector)
+{
+ struct intel_encoder *encoder =
+ intel_attached_encoder(to_intel_connector(connector));
+ struct drm_i915_private *dev_priv = to_i915(connector->dev);
+ bool lpsp_capable = false;
+
+ if (IS_TIGERLAKE(dev_priv) && encoder->port <= PORT_C) {
+ lpsp_capable = true;
+ } else if (INTEL_GEN(dev_priv) >= 11 && intel_have_embedded_panel(connector)) {
+ lpsp_capable = true;
+ } else if (INTEL_GEN(dev_priv) >= 9 && (encoder->port == PORT_A &&
+ !intel_have_hdmi_panel(connector))) {
+ lpsp_capable = true;
+ } else if (connector->connector_type == DRM_MODE_CONNECTOR_eDP) {
+ lpsp_capable = true;
+ }
+
+ lpsp_capable ? seq_puts(m, "LPSP capable\n") : seq_puts(m, "LPSP incapable\n");
+}
+
+static void
+intel_lpsp_enable_info(struct seq_file *m, struct drm_connector *connector)
+{
+ struct drm_i915_private *dev_priv = to_i915(connector->dev);
+ bool is_lpsp = false;
+
+ if (INTEL_GEN(dev_priv) >= 11)
+ is_lpsp = !intel_display_power_well_is_enabled(dev_priv,
+ ICL_DISP_PW_3);
+ else
+ is_lpsp = !intel_display_power_well_is_enabled(dev_priv,
+ SKL_DISP_PW_2);
+
+ is_lpsp ? seq_puts(m, "LPSP enabled\n") : seq_puts(m, "LPSP disabled\n");
+}
+
static void intel_dp_info(struct seq_file *m,
struct intel_connector *intel_connector)
{
@@ -1987,6 +2038,17 @@ static int i915_hdcp_sink_capability_show(struct seq_file *m, void *data)
}
DEFINE_SHOW_ATTRIBUTE(i915_hdcp_sink_capability);
+static int i915_lpsp_info_show(struct seq_file *m, void *data)
+{
+ struct drm_connector *connector = m->private;
+
+ intel_lpsp_capable_info(m, connector);
+ intel_lpsp_enable_info(m, connector);
+
+ return 0;
+}
+DEFINE_SHOW_ATTRIBUTE(i915_lpsp_info);
+
static int i915_dsc_fec_support_show(struct seq_file *m, void *data)
{
struct drm_connector *connector = m->private;
@@ -2130,5 +2192,8 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
debugfs_create_file("i915_dsc_fec_support", S_IRUGO, root,
connector, &i915_dsc_fec_support_fops);
+ debugfs_create_file("i915_lpsp_info", S_IRUGO, root,
+ connector, &i915_lpsp_info_fops);
+
return 0;
}
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.h b/drivers/gpu/drm/i915/display/intel_display_power.h
index 56cbae6327b7..14c5ad20287f 100644
--- a/drivers/gpu/drm/i915/display/intel_display_power.h
+++ b/drivers/gpu/drm/i915/display/intel_display_power.h
@@ -266,6 +266,8 @@ intel_display_power_domain_str(enum intel_display_power_domain domain);
bool intel_display_power_is_enabled(struct drm_i915_private *dev_priv,
enum intel_display_power_domain domain);
+bool intel_display_power_well_is_enabled(struct drm_i915_private *dev_priv,
+ enum i915_power_well_id power_well_id);
bool __intel_display_power_is_enabled(struct drm_i915_private *dev_priv,
enum intel_display_power_domain domain);
intel_wakeref_t intel_display_power_get(struct drm_i915_private *dev_priv,
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-12 14:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 14:07 [Intel-gfx] [PATCH 0/2] i915 lpsp support for lpsp igt Anshuman Gupta
2020-03-12 14:07 ` [Intel-gfx] [PATCH 1/2] drm/i915: Power well id for ICL PG3 Anshuman Gupta
2020-03-12 14:07 ` Anshuman Gupta [this message]
2020-03-12 15:25 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for i915 lpsp support for lpsp igt Patchwork
2020-03-13 4:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915 lpsp support for lpsp igt (rev2) Patchwork
2020-03-13 4:47 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312140702.14028-3-anshuman.gupta@intel.com \
--to=anshuman.gupta@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox