From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Albert Astals Cid <aacid@kde.org>,
intel-gfx@lists.freedesktop.org,
Matteo Iervasi <matteoiervasi@gmail.com>,
Emanuele Panigati <ilpanich@gmail.com>
Subject: Re: [Intel-gfx] [PATCH 1/3] drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure
Date: Thu, 19 Mar 2020 19:06:20 +0200 [thread overview]
Message-ID: <20200319170620.GO13686@intel.com> (raw)
In-Reply-To: <fd8d950b-13d2-ce85-ae03-3490551d3105@redhat.com>
On Thu, Mar 19, 2020 at 05:53:08PM +0100, Hans de Goede wrote:
> Hi,
>
> On 3/19/20 5:38 PM, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> >
> > Some new eDP panels don't like to operate at the max parameters, and
> > instead we need to go for an optimal confiugration. That unfortunately
> > doesn't work with older eDP panels which are generally only guaranteed
> > to work at the max parameters.
> >
> > To solve these two conflicting requirements let's start with the optimal
> > setup, and if that fails we start again with the max parameters. The
> > downside is probably an extra modeset when we switch strategies but
> > I don't see a good way to avoid that.
> >
> > For a bit of history we first tried to go for the fast+narrow in
> > commit 7769db588384 ("drm/i915/dp: optimize eDP 1.4+ link config
> > fast and narrow"). but that had to be reverted due to regression
> > on older panels in commit f11cb1c19ad0 ("drm/i915/dp: revert back
> > to max link rate and lane count on eDP"). So now we try to get
> > the best of both worlds by using both strategies.
> >
> > v2: Deal with output_bpp and uapi vs. hw state split
> > Reword some comments
>
> I'm wondering if, at least for the fastset case, but also
> for later modesets I guess, it would not be better to
> first check if the link is already setup (panel already on)
> and then check if the existing parameters match our min/max
> criteria and if they do continue with those settings?
>
> Doing something like this would likely also fix:
> https://gitlab.freedesktop.org/drm/intel/issues/1476
Yeah, I've thought about doing that. It's a bit ugly though, and
probably requires some actual thought so that we don't end up
doing something stupid.
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-19 17:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 16:38 [Intel-gfx] [PATCH 1/3] drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure Ville Syrjala
2020-03-19 16:38 ` [Intel-gfx] [PATCH 2/3] drm: Refactor intel_dp_compute_link_config_*() Ville Syrjala
2020-03-19 16:38 ` [Intel-gfx] [PATCH 3/3] drm: Constify adjusted_mode a bit Ville Syrjala
2020-03-20 18:33 ` Manasi Navare
2020-03-19 16:53 ` [Intel-gfx] [PATCH 1/3] drm/i915: Try to use fast+narrow link on eDP again and fall back to the old max strategy on failure Hans de Goede
2020-03-19 17:06 ` Ville Syrjälä [this message]
2020-03-19 17:46 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] " Patchwork
2020-03-19 19:52 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-03-19 22:20 ` [Intel-gfx] [PATCH 1/3] " Manasi Navare
2020-03-20 19:08 ` Ville Syrjälä
2020-03-20 23:17 ` Manasi Navare
2020-03-27 15:40 ` Ville Syrjälä
2020-03-27 18:09 ` Manasi Navare
2020-07-02 9:21 ` Timo Aaltonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200319170620.GO13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=aacid@kde.org \
--cc=hdegoede@redhat.com \
--cc=ilpanich@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=matteoiervasi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox