Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org, "José Roberto de Souza" <jose.souza@intel.com>
Cc: Cooper Chiou <cooper.chiou@intel.com>,
	intel-gfx@lists.freedesktop.org,
	Kai-Heng Feng <kai.heng.feng@canonical.com>,
	kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 5/6] drm/i915/tc/icl: Implement the TC cold exit sequence
Date: Fri, 20 Mar 2020 16:11:12 +0300	[thread overview]
Message-ID: <20200320131112.GG4650@kadam> (raw)
In-Reply-To: <20200318235956.118409-5-jose.souza@intel.com>

Hi "José,

Thank you for the patch! Perhaps something to improve:

url:    https://github.com/0day-ci/linux/commits/Jos-Roberto-de-Souza/drm-i915-tc-tgl-Implement-TCCOLD-sequences/20200319-080253
base:   git://anongit.freedesktop.org/drm-intel for-linux-next

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
drivers/gpu/drm/i915/display/intel_tc.c:554 icl_tc_cold_request() error: uninitialized symbol 'ret'.

# https://github.com/0day-ci/linux/commit/29f27e6df6ad82b09a3c9ddaf5f51b2fc1647178
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 29f27e6df6ad82b09a3c9ddaf5f51b2fc1647178
vim +/ret +554 drivers/gpu/drm/i915/display/intel_tc.c

29f27e6df6ad82 José Roberto de Souza 2020-03-18  528  static inline int icl_tc_cold_request(struct intel_digital_port *dig_port,
29f27e6df6ad82 José Roberto de Souza 2020-03-18  529  				      bool block)
29f27e6df6ad82 José Roberto de Souza 2020-03-18  530  {
29f27e6df6ad82 José Roberto de Souza 2020-03-18  531  	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
29f27e6df6ad82 José Roberto de Souza 2020-03-18  532  	enum intel_display_power_domain aux_domain;
29f27e6df6ad82 José Roberto de Souza 2020-03-18  533  	int ret;
29f27e6df6ad82 José Roberto de Souza 2020-03-18  534  
29f27e6df6ad82 José Roberto de Souza 2020-03-18  535  	aux_domain = intel_aux_ch_to_power_domain(dig_port->aux_ch);
29f27e6df6ad82 José Roberto de Souza 2020-03-18  536  
29f27e6df6ad82 José Roberto de Souza 2020-03-18  537  	if (block) {
29f27e6df6ad82 José Roberto de Souza 2020-03-18  538  		dig_port->tc_cold_wakeref =
29f27e6df6ad82 José Roberto de Souza 2020-03-18  539  			intel_display_power_get_without_ack(i915, aux_domain);
29f27e6df6ad82 José Roberto de Souza 2020-03-18  540  
29f27e6df6ad82 José Roberto de Souza 2020-03-18  541  		do {
29f27e6df6ad82 José Roberto de Souza 2020-03-18  542  			ret = sandybridge_pcode_write_timeout(i915,
29f27e6df6ad82 José Roberto de Souza 2020-03-18  543  							      ICL_PCODE_EXIT_TCCOLD,
29f27e6df6ad82 José Roberto de Souza 2020-03-18  544  							      0, 250, 1);
29f27e6df6ad82 José Roberto de Souza 2020-03-18  545  
29f27e6df6ad82 José Roberto de Souza 2020-03-18  546  		} while (ret == -EAGAIN);

ret is only initialized on this path

29f27e6df6ad82 José Roberto de Souza 2020-03-18  547  	} else if (dig_port->tc_mode == TC_PORT_LEGACY) {
29f27e6df6ad82 José Roberto de Souza 2020-03-18  548  		drm_WARN_ON(&i915->drm, !dig_port->tc_lock_wakeref);
29f27e6df6ad82 José Roberto de Souza 2020-03-18  549  		intel_display_power_put(i915, aux_domain,
29f27e6df6ad82 José Roberto de Souza 2020-03-18  550  					dig_port->tc_cold_wakeref);
29f27e6df6ad82 José Roberto de Souza 2020-03-18  551  		dig_port->tc_cold_wakeref = 0;
29f27e6df6ad82 José Roberto de Souza 2020-03-18  552  	}
29f27e6df6ad82 José Roberto de Souza 2020-03-18  553  
29f27e6df6ad82 José Roberto de Souza 2020-03-18 @554  	return ret;
29f27e6df6ad82 José Roberto de Souza 2020-03-18  555  }

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-03-20 13:11 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-18 23:59 [Intel-gfx] [PATCH 1/6] drm/i915/tc/tgl: Implement TCCOLD sequences José Roberto de Souza
2020-03-18 23:59 ` [Intel-gfx] [PATCH 2/6] drm/i915/display: Add intel_display_power_get_without_ack() José Roberto de Souza
2020-03-18 23:59 ` [Intel-gfx] [PATCH 3/6] drm/i915/display: Implement intel_display_power_wait_enable_ack() José Roberto de Souza
2020-03-18 23:59 ` [Intel-gfx] [PATCH 4/6] drm/i915/display: Add intel_aux_ch_to_power_domain() José Roberto de Souza
2020-03-18 23:59 ` [Intel-gfx] [PATCH 5/6] drm/i915/tc/icl: Implement the TC cold exit sequence José Roberto de Souza
2020-03-19 17:45   ` [Intel-gfx] [PATCH v2 " José Roberto de Souza
2020-03-20 13:11   ` Dan Carpenter [this message]
2020-03-20 19:52     ` [Intel-gfx] [PATCH " Souza, Jose
2020-03-18 23:59 ` [Intel-gfx] [PATCH 6/6] drm/i915/dp: Get TC link reference during DP detection José Roberto de Souza
2020-03-19  0:37 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915/tc/tgl: Implement TCCOLD sequences Patchwork
2020-03-19  2:34 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-19 20:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915/tc/tgl: Implement TCCOLD sequences (rev2) Patchwork
2020-03-19 22:50 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200320131112.GG4650@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=cooper.chiou@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    --cc=kai.heng.feng@canonical.com \
    --cc=kbuild-all@lists.01.org \
    --cc=kbuild@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox