From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Uma Shankar <uma.shankar@intel.com>
Cc: SweeAun Khor <swee.aun.khor@intel.com>,
intel-gfx@lists.freedesktop.org, Souza@freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check
Date: Thu, 26 Mar 2020 18:17:01 +0200 [thread overview]
Message-ID: <20200326161701.GD13686@intel.com> (raw)
In-Reply-To: <20200326074928.10395-1-uma.shankar@intel.com>
On Thu, Mar 26, 2020 at 01:19:28PM +0530, Uma Shankar wrote:
> This patch fixes the private_flags of mode to be checked and
> compared against uapi.mode and not from hw.mode. This helps
> properly trigger modeset at boot if desired by driver.
>
> It helps resolve audio_codec initialization issues if display
> is connected at boot. Initial discussion on this issue has happened
> on below thread:
> https://patchwork.freedesktop.org/series/74828/
>
> Fixes: https://gitlab.freedesktop.org/drm/intel/issues/1363
>
> Cc: Ville Syrjä <ville.syrjala@linux.intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>
> Cc: Souza, Jose <jose.souza@intel.com>
> Suggested-by: Ville Syrjä <ville.syrjala@linux.intel.com>
No one by that name here.
> Signed-off-by: Uma Shankar <uma.shankar@intel.com>
> Signed-off-by: SweeAun Khor <swee.aun.khor@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index fe55c7c713f1..e630429af2c0 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -14747,8 +14747,8 @@ static int intel_atomic_check(struct drm_device *dev,
> /* Catch I915_MODE_FLAG_INHERITED */
> for_each_oldnew_intel_crtc_in_state(state, crtc, old_crtc_state,
> new_crtc_state, i) {
> - if (new_crtc_state->hw.mode.private_flags !=
> - old_crtc_state->hw.mode.private_flags)
> + if (new_crtc_state->uapi.mode.private_flags !=
> + old_crtc_state->uapi.mode.private_flags)
> new_crtc_state->uapi.mode_changed = true;
> }
>
> --
> 2.22.0
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-26 16:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 7:49 [Intel-gfx] [PATCH] drm/i915/display: Fix mode private_flags comparison at atomic_check Uma Shankar
2020-03-26 8:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-03-26 9:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-03-26 10:47 ` [Intel-gfx] [PATCH] " Maarten Lankhorst
2020-03-26 11:59 ` Shankar, Uma
2020-03-26 16:17 ` Ville Syrjälä [this message]
2020-03-26 17:45 ` Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200326161701.GD13686@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=Souza@freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=swee.aun.khor@intel.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox