From: Sam Ravnborg <sam@ravnborg.org>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [Intel-gfx] [PATCH v2 05/17] drm: Shrink {width, height}_mm to u16
Date: Tue, 7 Apr 2020 20:37:54 +0200 [thread overview]
Message-ID: <20200407183754.GE6356@ravnborg.org> (raw)
In-Reply-To: <20200403204008.14864-6-ville.syrjala@linux.intel.com>
On Fri, Apr 03, 2020 at 11:39:56PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Instead of supporting ~2000km wide displayes let's limit ourselves
> to ~65m. That seems plenty big enough to me.
>
> Even with EDID_QUIRK_DETAILED_IN_CM EDIDs seem to be limited to
> 10*0xfff which fits into the 16 bits.
>
> Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
> ---
> include/drm/drm_modes.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/drm/drm_modes.h b/include/drm/drm_modes.h
> index 8b05f3705d0e..3625e3681488 100644
> --- a/include/drm/drm_modes.h
> +++ b/include/drm/drm_modes.h
> @@ -330,7 +330,7 @@ struct drm_display_mode {
> * Addressable size of the output in mm, projectors should set this to
> * 0.
> */
> - int width_mm;
> + u16 width_mm;
>
> /**
> * @height_mm:
> @@ -338,7 +338,7 @@ struct drm_display_mode {
> * Addressable size of the output in mm, projectors should set this to
> * 0.
> */
> - int height_mm;
> + u16 height_mm;
>
> /**
> * @crtc_clock:
> --
> 2.24.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-04-07 18:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 20:39 [Intel-gfx] [PATCH v2 00/17] drm: Put drm_display_mode on diet Ville Syrjala
2020-04-03 20:39 ` [Intel-gfx] [PATCH v2 01/17] drm: Nuke mode->hsync Ville Syrjala
2020-04-07 18:30 ` Sam Ravnborg
2020-04-03 20:39 ` [Intel-gfx] [PATCH v2 02/17] drm/i915: Introduce some local intel_dp variables Ville Syrjala
2020-04-03 20:39 ` [Intel-gfx] [PATCH v2 03/17] drm: Nuke mode->vrefresh Ville Syrjala
2020-04-03 20:58 ` Laurent Pinchart
2020-04-04 2:01 ` abhinavk
2020-04-06 8:32 ` Jani Nikula
2020-04-07 1:23 ` abhinavk
2020-04-03 20:39 ` [Intel-gfx] [PATCH v2 04/17] drm/msm/dpu: Stop copying around mode->private_flags Ville Syrjala
2020-04-03 20:39 ` [Intel-gfx] [PATCH v2 05/17] drm: Shrink {width,height}_mm to u16 Ville Syrjala
2020-04-07 18:37 ` Sam Ravnborg [this message]
2020-04-03 20:39 ` [Intel-gfx] [PATCH v2 06/17] drm: Shrink mode->type to u8 Ville Syrjala
2020-04-07 18:38 ` Sam Ravnborg
2020-04-03 20:39 ` [Intel-gfx] [PATCH v2 07/17] drm: Make mode->flags u32 Ville Syrjala
2020-04-07 18:38 ` Sam Ravnborg
2020-04-03 20:39 ` [Intel-gfx] [PATCH v2 08/17] drm: Shrink drm_display_mode timings Ville Syrjala
2020-04-07 18:43 ` Sam Ravnborg
2020-04-03 20:40 ` [Intel-gfx] [PATCH v2 09/17] drm: Flatten drm_mode_vrefresh() Ville Syrjala
2020-04-07 18:46 ` Sam Ravnborg
2020-04-03 20:40 ` [Intel-gfx] [PATCH v2 10/17] drm: Shrink mode->private_flags Ville Syrjala
2020-04-07 18:52 ` Sam Ravnborg
2020-04-07 19:10 ` Ville Syrjälä
2020-04-03 20:40 ` [Intel-gfx] [PATCH v2 11/17] drm: pahole struct drm_display_mode Ville Syrjala
2020-04-03 20:40 ` [Intel-gfx] [PATCH v2 12/17] drm/mcde: Use mode->clock instead of reverse calculating it from the vrefresh Ville Syrjala
2020-04-07 7:27 ` Daniel Vetter
2020-04-07 18:53 ` Sam Ravnborg
2020-04-12 0:42 ` Linus Walleij
2020-04-03 20:40 ` [Intel-gfx] [PATCH v2 13/17] drm/i915: Stop using mode->private_flags Ville Syrjala
2020-04-07 7:38 ` Daniel Vetter
2020-04-07 15:20 ` Ville Syrjälä
2020-04-08 9:34 ` Jani Nikula
2020-04-03 20:40 ` [Intel-gfx] [PATCH v2 14/17] drm/i915: Replace I915_MODE_FLAG_INHERITED with a boolean Ville Syrjala
2020-04-07 7:42 ` Daniel Vetter
2020-04-03 20:40 ` [Intel-gfx] [PATCH v2 15/17] drm/gma500: Stop using mode->private_flags Ville Syrjala
2020-04-07 7:46 ` Daniel Vetter
2020-04-07 18:56 ` Sam Ravnborg
2020-04-07 19:08 ` Ville Syrjälä
2020-04-07 19:35 ` Sam Ravnborg
2020-04-09 19:49 ` Ville Syrjälä
2020-04-09 19:54 ` Ville Syrjälä
2020-04-09 20:47 ` Sam Ravnborg
2020-04-14 15:11 ` Ville Syrjälä
2020-04-03 20:40 ` [Intel-gfx] [PATCH v2 16/17] drm: Nuke mode->private_flags Ville Syrjala
2020-04-04 1:40 ` abhinavk
2020-04-06 9:11 ` Jani Nikula
2020-04-07 1:26 ` abhinavk
2020-04-07 18:58 ` Sam Ravnborg
2020-04-03 20:40 ` [Intel-gfx] [PATCH v2 17/17] drm: Replace mode->export_head with a boolean Ville Syrjala
2020-04-03 22:04 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Put drm_display_mode on diet (rev2) Patchwork
2020-04-03 22:29 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-04-24 17:32 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for drm: Put drm_display_mode on diet (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200407183754.GE6356@ravnborg.org \
--to=sam@ravnborg.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox