From: Andi Shyti <andi.shyti@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Drop rq->ring->vma peeking from error capture
Date: Fri, 24 Apr 2020 23:51:40 +0300 [thread overview]
Message-ID: <20200424205140.GB1429@intel.intel> (raw)
In-Reply-To: <20200424191410.27570-1-chris@chris-wilson.co.uk>
> static void engine_record_execlists(struct intel_engine_coredump *ee)
> @@ -1231,8 +1235,10 @@ static void engine_record_execlists(struct intel_engine_coredump *ee)
> struct i915_request * const *port = el->active;
> unsigned int n = 0;
>
> - while (*port)
> - record_request(*port++, &ee->execlist[n++]);
> + while (*port) {
> + if (record_request(*port++, &ee->execlist[n]))
> + n++;
> + }
grrrr.... is this necessary?
Besides, in a one line while loop we aren't supposed to use
braces.
Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-04-24 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-24 19:14 [Intel-gfx] [PATCH] drm/i915: Drop rq->ring->vma peeking from error capture Chris Wilson
2020-04-24 19:48 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-04-24 20:38 ` [Intel-gfx] [PATCH] " Mika Kuoppala
2020-04-24 20:51 ` Andi Shyti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200424205140.GB1429@intel.intel \
--to=andi.shyti@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox