Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Alexei Podtelezhnikov <apodtele@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [patch] PCI ID review
Date: Mon, 27 Apr 2020 17:02:48 +0300	[thread overview]
Message-ID: <20200427140248.GG6112@intel.com> (raw)
In-Reply-To: <20200427032232.4307-1-apodtele@gmail.com>

On Sun, Apr 26, 2020 at 11:22:32PM -0400, Alexei Podtelezhnikov wrote:
> In reverse order:
> - Add SKL GT1.5
> - Remove wrong and non-existant devices
> - Add Gen3/Gen4 twin IGDs
> - Amend historic records 

Please split into separate patches and justify each with
a proper commit message.

> 
> Signed-off-by: Alexei Podtelezhnikov <apodtele@gmail.com>
> ---
>  src/i915_pciids.h | 72 +++++++++++++++++++++++++++++++++++++------------------
>  1 file changed, 49 insertions(+), 23 deletions(-)
> 
> diff --git a/src/i915_pciids.h b/src/i915_pciids.h
> index 1d2c1221..a9c88eab 100644
> --- a/src/i915_pciids.h
> +++ b/src/i915_pciids.h
> @@ -47,7 +47,11 @@ Amend historic records
>  	0x030000, 0xff0000,			\
>  	(unsigned long) info }
>  
> +#define INTEL_I740_IDS(info)					\
> +	INTEL_VGA_DEVICE(0x7800, info)  /* I740 */
> +
>  #define INTEL_I810_IDS(info)					\
> +	INTEL_VGA_DEVICE(0x1240, info), /* I752 */		\
>  	INTEL_VGA_DEVICE(0x7121, info), /* I810 */		\
>  	INTEL_VGA_DEVICE(0x7123, info), /* I810_DC100 */	\
>  	INTEL_VGA_DEVICE(0x7125, info)  /* I810_E */
> @@ -62,57 +66,79 @@ Add Gen3/Gen4 twin IGDs
>  	INTEL_VGA_DEVICE(0x2562, info)
>  
>  #define INTEL_I85X_IDS(info)				\
> -	INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */ \
> -	INTEL_VGA_DEVICE(0x358e, info)
> +	INTEL_VGA_DEVICE(0x3582, info), /* I855_GM */   \
> +	INTEL_VGA_DEVICE(0x358e, info)  /* I854 */
>  
>  #define INTEL_I865G_IDS(info)				\
>  	INTEL_VGA_DEVICE(0x2572, info) /* I865_G */
>  
>  #define INTEL_I915G_IDS(info)				\
> -	INTEL_VGA_DEVICE(0x2582, info), /* I915_G */ \
> +	INTEL_VGA_DEVICE(0x2582, info), /* I915_G */    \
> +	INTEL_VGA_DEVICE(0x2782, info), /* I915_G */    \
>  	INTEL_VGA_DEVICE(0x258a, info)  /* E7221_G */
>  
>  #define INTEL_I915GM_IDS(info)				\
> -	INTEL_VGA_DEVICE(0x2592, info) /* I915_GM */
> +	INTEL_VGA_DEVICE(0x2592, info), /* I915_GM */   \
> +	INTEL_VGA_DEVICE(0x2792, info)  /* I915_GM */
>  
>  #define INTEL_I945G_IDS(info)				\
> -	INTEL_VGA_DEVICE(0x2772, info) /* I945_G */
> +	INTEL_VGA_DEVICE(0x2772, info), /* I945_G */    \
> +	INTEL_VGA_DEVICE(0x2776, info)  /* I945_G */
>  
>  #define INTEL_I945GM_IDS(info)				\
> -	INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */ \
> +	INTEL_VGA_DEVICE(0x27a2, info), /* I945_GM */   \
> +	INTEL_VGA_DEVICE(0x27a6, info), /* I945_GM */   \
>  	INTEL_VGA_DEVICE(0x27ae, info)  /* I945_GME */
>  
>  #define INTEL_I965G_IDS(info)				\
>  	INTEL_VGA_DEVICE(0x2972, info), /* I946_GZ */	\
> +	INTEL_VGA_DEVICE(0x2973, info), /* I946_GZ */	\
>  	INTEL_VGA_DEVICE(0x2982, info),	/* G35_G */	\
> +	INTEL_VGA_DEVICE(0x2983, info),	/* G35_G */	\
>  	INTEL_VGA_DEVICE(0x2992, info),	/* I965_Q */	\
> -	INTEL_VGA_DEVICE(0x29a2, info)	/* I965_G */
> +	INTEL_VGA_DEVICE(0x2993, info),	/* I965_Q */	\
> +	INTEL_VGA_DEVICE(0x29a2, info),	/* I965_G */    \
> +	INTEL_VGA_DEVICE(0x29a3, info)	/* I965_G */
>  
>  #define INTEL_G33_IDS(info)				\
>  	INTEL_VGA_DEVICE(0x29b2, info), /* Q35_G */ \
> +	INTEL_VGA_DEVICE(0x29b3, info), /* Q35_G */ \
>  	INTEL_VGA_DEVICE(0x29c2, info),	/* G33_G */ \
> -	INTEL_VGA_DEVICE(0x29d2, info)	/* Q33_G */
> +	INTEL_VGA_DEVICE(0x29c3, info),	/* G33_G */ \
> +	INTEL_VGA_DEVICE(0x29d2, info),	/* Q33_G */ \
> +	INTEL_VGA_DEVICE(0x29d3, info)	/* Q33_G */
>  
>  #define INTEL_I965GM_IDS(info)				\
> -	INTEL_VGA_DEVICE(0x2a02, info),	/* I965_GM */ \
> -	INTEL_VGA_DEVICE(0x2a12, info)  /* I965_GME */
> +	INTEL_VGA_DEVICE(0x2a02, info),	/* I965_GM */   \
> +	INTEL_VGA_DEVICE(0x2a03, info),	/* I965_GM */   \
> +	INTEL_VGA_DEVICE(0x2a12, info), /* I965_GME */  \
> +	INTEL_VGA_DEVICE(0x2a13, info)  /* I965_GME */
>  
>  #define INTEL_GM45_IDS(info)				\
> -	INTEL_VGA_DEVICE(0x2a42, info) /* GM45_G */
> +	INTEL_VGA_DEVICE(0x2a42, info), /* GM45_G */    \
> +	INTEL_VGA_DEVICE(0x2a43, info)  /* GM45_G */
>  
>  #define INTEL_G45_IDS(info)				\
> -	INTEL_VGA_DEVICE(0x2e02, info), /* IGD_E_G */ \
> -	INTEL_VGA_DEVICE(0x2e12, info), /* Q45_G */ \
> -	INTEL_VGA_DEVICE(0x2e22, info), /* G45_G */ \
> -	INTEL_VGA_DEVICE(0x2e32, info), /* G41_G */ \
> -	INTEL_VGA_DEVICE(0x2e42, info), /* B43_G */ \
> -	INTEL_VGA_DEVICE(0x2e92, info)	/* B43_G.1 */
> +	INTEL_VGA_DEVICE(0x2e02, info), /* IGD_E_G */   \
> +	INTEL_VGA_DEVICE(0x2e03, info), /* IGD_E_G */   \
> +	INTEL_VGA_DEVICE(0x2e12, info), /* Q45_G */     \
> +	INTEL_VGA_DEVICE(0x2e13, info), /* Q45_G */     \
> +	INTEL_VGA_DEVICE(0x2e22, info), /* G45_G */     \
> +	INTEL_VGA_DEVICE(0x2e23, info), /* G45_G */     \
> +	INTEL_VGA_DEVICE(0x2e32, info), /* G41_G */     \
> +	INTEL_VGA_DEVICE(0x2e33, info), /* G41_G */     \
> +	INTEL_VGA_DEVICE(0x2e42, info), /* B43_G */     \
> +	INTEL_VGA_DEVICE(0x2e43, info), /* B43_G */     \
> +	INTEL_VGA_DEVICE(0x2e92, info),	/* B43_G.1 */   \
> +	INTEL_VGA_DEVICE(0x2e93, info)	/* B43_G.1 */
>  
>  #define INTEL_PINEVIEW_G_IDS(info) \
> -	INTEL_VGA_DEVICE(0xa001, info)
> +	INTEL_VGA_DEVICE(0xa001, info), \
> +	INTEL_VGA_DEVICE(0xa002, info)
>  
>  #define INTEL_PINEVIEW_M_IDS(info) \
> -	INTEL_VGA_DEVICE(0xa011, info)
> +	INTEL_VGA_DEVICE(0xa011, info), \
> +	INTEL_VGA_DEVICE(0xa012, info)
>  
>  #define INTEL_IRONLAKE_D_IDS(info) \
>  	INTEL_VGA_DEVICE(0x0042, info)
> @@ -258,9 +284,7 @@ Remove wrong and non-existant devices
>  	INTEL_VGA_DEVICE(0x0f30, info), \
>  	INTEL_VGA_DEVICE(0x0f31, info), \
>  	INTEL_VGA_DEVICE(0x0f32, info), \
> -	INTEL_VGA_DEVICE(0x0f33, info), \
> -	INTEL_VGA_DEVICE(0x0157, info), \
> -	INTEL_VGA_DEVICE(0x0155, info)
> +	INTEL_VGA_DEVICE(0x0f33, info)
>  
>  #define INTEL_BDW_ULT_GT1_IDS(info) \
>  	INTEL_VGA_DEVICE(0x1606, info), /* GT1 ULT */ \
> @@ -331,7 +355,8 @@ Add SKL GT1.5
>  	INTEL_VGA_DEVICE(0x22b3, info)
>  
>  #define INTEL_SKL_ULT_GT1_IDS(info) \
> -	INTEL_VGA_DEVICE(0x1906, info) /* ULT GT1 */
> +	INTEL_VGA_DEVICE(0x1906, info), /* ULT GT1 */ \
> +	INTEL_VGA_DEVICE(0x1913, info) /* ULT GT1.5 */
>  
>  #define INTEL_SKL_ULX_GT1_IDS(info) \
>  	INTEL_VGA_DEVICE(0x190E, info) /* ULX GT1 */
> @@ -340,6 +365,7 @@ Add SKL GT1.5
>  	INTEL_SKL_ULT_GT1_IDS(info), \
>  	INTEL_SKL_ULX_GT1_IDS(info), \
>  	INTEL_VGA_DEVICE(0x1902, info), /* DT  GT1 */ \
> +	INTEL_VGA_DEVICE(0x1917, info), /* DT  GT1.5 */ \
>  	INTEL_VGA_DEVICE(0x190B, info), /* Halo GT1 */ \
>  	INTEL_VGA_DEVICE(0x190A, info) /* SRV GT1 */
>  
> --
> 2.26.1
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2020-04-27 14:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27  3:22 [Intel-gfx] [patch] PCI ID review Alexei Podtelezhnikov
2020-04-27  3:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-04-27  4:15 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-04-27  5:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-04-27 14:02 ` Ville Syrjälä [this message]
2020-04-27 14:14   ` [Intel-gfx] [patch] " Chris Wilson
2020-04-27 14:40     ` Alexei Podtelezhnikov
2020-04-27 14:45       ` Chris Wilson
2020-04-27 15:18         ` Alexei Podtelezhnikov
2020-04-27 17:07           ` Rodrigo Vivi
2020-04-27 22:14             ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200427140248.GG6112@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=apodtele@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox