From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org,
Lionel Landwerlin <lionel.g.landwerlin@intel.com>,
intel-gfx@lists.freedesktop.org
Cc: kbuild-all@lists.01.org, chris@chris-wilson.co.uk
Subject: [Intel-gfx] [kbuild] Re: [PATCH v12 3/4] drm/i915/perf: prepare driver to receive multiple ctx handles
Date: Thu, 7 May 2020 17:42:33 +0300 [thread overview]
Message-ID: <20200507144233.GO1992@kadam> (raw)
In-Reply-To: <20200504111249.1367096-4-lionel.g.landwerlin@intel.com>
Hi Lionel,
Thank you for the patch! Perhaps something to improve:
url: https://github.com/0day-ci/linux/commits/Lionel-Landwerlin/drm-i915-perf-Add-support-for-multi-context-perf-queries/20200505-060720
base: git://anongit.freedesktop.org/drm-intel for-linux-next
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/i915_perf.c:1457 i915_oa_stream_destroy() error: uninitialized symbol 'err'.
Old smatch warnings:
drivers/gpu/drm/i915/i915_perf.c:1383 oa_get_render_ctx_ids() error: double unlocked 'ctx->engines_mutex' (orig line 1351)
drivers/gpu/drm/i915/i915_perf.c:3044 i915_oa_stream_init() error: uninitialized symbol 'timeline'.
drivers/gpu/drm/i915/i915_perf.c:3664 i915_perf_open_ioctl_locked() error: uninitialized symbol 'ret'.
# https://github.com/0day-ci/linux/commit/dc9d77b54dfbfd0de4e30e59d29d5216b80a51b2
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout dc9d77b54dfbfd0de4e30e59d29d5216b80a51b2
vim +/err +1457 drivers/gpu/drm/i915/i915_perf.c
307ca63ef54097 Lionel Landwerlin 2020-05-04 1441
d79651522e89c4 Robert Bragg 2016-11-07 1442 static void i915_oa_stream_destroy(struct i915_perf_stream *stream)
d79651522e89c4 Robert Bragg 2016-11-07 1443 {
8f8b1171e1a514 Chris Wilson 2019-10-07 1444 struct i915_perf *perf = stream->perf;
307ca63ef54097 Lionel Landwerlin 2020-05-04 1445 int err;
^^^^^^^
d79651522e89c4 Robert Bragg 2016-11-07 1446
8f8b1171e1a514 Chris Wilson 2019-10-07 1447 BUG_ON(stream != perf->exclusive_stream);
d79651522e89c4 Robert Bragg 2016-11-07 1448
19f81df2859eb1 Robert Bragg 2017-06-13 1449 /*
f89823c212246d Lionel Landwerlin 2017-08-03 1450 * Unset exclusive_stream first, it will be checked while disabling
f89823c212246d Lionel Landwerlin 2017-08-03 1451 * the metric set on gen8+.
a5af081d012e8b Chris Wilson 2020-02-27 1452 *
a5af081d012e8b Chris Wilson 2020-02-27 1453 * See i915_oa_init_reg_state() and lrc_configure_all_contexts()
19f81df2859eb1 Robert Bragg 2017-06-13 1454 */
a5af081d012e8b Chris Wilson 2020-02-27 1455 WRITE_ONCE(perf->exclusive_stream, NULL);
dc9d77b54dfbfd Lionel Landwerlin 2020-05-04 1456
dc9d77b54dfbfd Lionel Landwerlin 2020-05-04 @1457 if (!err) {
^^^^^
Uninitialized
307ca63ef54097 Lionel Landwerlin 2020-05-04 1458 err = i915_perf_stream_sync(stream, false /* enable */);
307ca63ef54097 Lionel Landwerlin 2020-05-04 1459 if (err) {
307ca63ef54097 Lionel Landwerlin 2020-05-04 1460 drm_err(&perf->i915->drm,
307ca63ef54097 Lionel Landwerlin 2020-05-04 1461 "Error while disabling OA stream\n");
307ca63ef54097 Lionel Landwerlin 2020-05-04 1462 }
dc9d77b54dfbfd Lionel Landwerlin 2020-05-04 1463 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild@lists.01.org
To unsubscribe send an email to kbuild-leave@lists.01.org
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-05-07 14:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 11:12 [Intel-gfx] [PATCH v12 0/4] drm/i915/perf: Add support for multi context perf queries Lionel Landwerlin
2020-05-04 11:12 ` [Intel-gfx] [PATCH v12 1/4] drm/i915/perf: break OA config buffer object in 2 Lionel Landwerlin
2020-05-04 11:12 ` [Intel-gfx] [PATCH v12 2/4] drm/i915/perf: stop using the kernel context Lionel Landwerlin
2020-05-04 11:22 ` Chris Wilson
2020-05-04 11:12 ` [Intel-gfx] [PATCH v12 3/4] drm/i915/perf: prepare driver to receive multiple ctx handles Lionel Landwerlin
2020-05-04 11:21 ` Chris Wilson
2020-05-07 14:42 ` Dan Carpenter [this message]
2020-05-04 11:12 ` [Intel-gfx] [PATCH v12 4/4] drm/i915/perf: enable filtering on multiple contexts Lionel Landwerlin
2020-05-04 11:23 ` Chris Wilson
2020-05-06 12:04 ` Lionel Landwerlin
2020-05-06 12:06 ` Lionel Landwerlin
2020-05-06 12:14 ` Chris Wilson
2020-05-04 11:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: Add support for multi context perf queries (rev6) Patchwork
2020-05-04 20:51 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507144233.GO1992@kadam \
--to=dan.carpenter@oracle.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kbuild-all@lists.01.org \
--cc=kbuild@lists.01.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox