From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Kunal Joshi <kunal1.joshi@intel.com>,
stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/icl+: Fix hotplug interrupt disabling after storm detection
Date: Fri, 12 Jun 2020 16:18:48 +0300 [thread overview]
Message-ID: <20200612131848.GH6112@intel.com> (raw)
In-Reply-To: <20200612121731.19596-1-imre.deak@intel.com>
On Fri, Jun 12, 2020 at 03:17:31PM +0300, Imre Deak wrote:
> Atm, hotplug interrupts on TypeC ports are left enabled after detecting
> an interrupt storm, fix this.
>
> Reported-by: Kunal Joshi <kunal1.joshi@intel.com>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/351
> Bugzilla: https://gitlab.freedesktop.org/drm/intel/-/issues/1964
> Cc: Kunal Joshi <kunal1.joshi@intel.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/i915_irq.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 8e823ba25f5f..710224d930c5 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -3132,6 +3132,7 @@ static void gen11_hpd_irq_setup(struct drm_i915_private *dev_priv)
>
> val = I915_READ(GEN11_DE_HPD_IMR);
> val &= ~hotplug_irqs;
> + val |= ~enabled_irqs & hotplug_irqs;
> I915_WRITE(GEN11_DE_HPD_IMR, val);
> POSTING_READ(GEN11_DE_HPD_IMR);
Wondering if we should add a function for this just
for consistency with all the other platforms. Alhthough
we don't strictly need one since we have no other users
of this register. So maybe not.
Anyways, patch is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> --
> 2.23.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-12 13:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 12:17 [Intel-gfx] [PATCH] drm/i915/icl+: Fix hotplug interrupt disabling after storm detection Imre Deak
2020-06-12 13:04 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2020-06-12 13:20 ` Imre Deak
2020-06-12 20:13 ` Vudum, Lakshminarayana
2020-06-12 13:18 ` Ville Syrjälä [this message]
2020-06-15 6:59 ` [Intel-gfx] [PATCH] " Imre Deak
2020-06-12 20:07 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-06-12 22:07 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612131848.GH6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox