From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: "Souza, Jose" <jose.souza@intel.com>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 2/6] drm/i915: Add plane damage clips property
Date: Fri, 12 Jun 2020 18:37:56 +0300 [thread overview]
Message-ID: <20200612153756.GJ6112@intel.com> (raw)
In-Reply-To: <023ae7594ee3fa1e94d51686b778b55c12e99c96.camel@intel.com>
On Fri, Jun 12, 2020 at 03:30:59PM +0000, Souza, Jose wrote:
> On Fri, 2020-06-12 at 18:25 +0300, Ville Syrjälä wrote:
> > On Tue, May 26, 2020 at 03:14:43PM -0700, José Roberto de Souza wrote:
> > > This property will be used by PSR2 software tracking, adding it to
> > > GEN12+.
> >
> > Is there actual userspace that uses this?
>
> Only Weston for now:
>
> https://gitlab.freedesktop.org/wayland/weston/-/merge_requests/17
And what happens when userspace doesn't do this stuff?
>
> >
> > > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/intel_display.c | 4 ++++
> > > drivers/gpu/drm/i915/display/intel_sprite.c | 4 ++++
> > > 2 files changed, 8 insertions(+)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> > > index f40b909952cc..b69878334040 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_display.c
> > > @@ -35,6 +35,7 @@
> > > #include <drm/drm_atomic.h>
> > > #include <drm/drm_atomic_helper.h>
> > > #include <drm/drm_atomic_uapi.h>
> > > +#include <drm/drm_damage_helper.h>
> > > #include <drm/drm_dp_helper.h>
> > > #include <drm/drm_edid.h>
> > > #include <drm/drm_fourcc.h>
> > > @@ -16476,6 +16477,9 @@ intel_cursor_plane_create(struct drm_i915_private *dev_priv,
> > > zpos = RUNTIME_INFO(dev_priv)->num_sprites[pipe] + 1;
> > > drm_plane_create_zpos_immutable_property(&cursor->base, zpos);
> > >
> > > + if (INTEL_GEN(dev_priv) >= 12)
> > > + drm_plane_enable_fb_damage_clips(&cursor->base);
> > > +
> > > drm_plane_helper_add(&cursor->base, &intel_plane_helper_funcs);
> > >
> > > return cursor;
> > > diff --git a/drivers/gpu/drm/i915/display/intel_sprite.c b/drivers/gpu/drm/i915/display/intel_sprite.c
> > > index 571c36f929bd..8be06cb25999 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_sprite.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_sprite.c
> > > @@ -34,6 +34,7 @@
> > > #include <drm/drm_atomic_helper.h>
> > > #include <drm/drm_color_mgmt.h>
> > > #include <drm/drm_crtc.h>
> > > +#include <drm/drm_damage_helper.h>
> > > #include <drm/drm_fourcc.h>
> > > #include <drm/drm_plane_helper.h>
> > > #include <drm/drm_rect.h>
> > > @@ -3151,6 +3152,9 @@ skl_universal_plane_create(struct drm_i915_private *dev_priv,
> > >
> > > drm_plane_create_zpos_immutable_property(&plane->base, plane_id);
> > >
> > > + if (INTEL_GEN(dev_priv) >= 12)
> > > + drm_plane_enable_fb_damage_clips(&plane->base);
> > > +
> > > drm_plane_helper_add(&plane->base, &intel_plane_helper_funcs);
> > >
> > > return plane;
> > > --
> > > 2.26.2
> > >
> > > _______________________________________________
> > > Intel-gfx mailing list
> > > Intel-gfx@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-12 15:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-26 22:14 [Intel-gfx] [PATCH 1/6] drm/i915/rkl: Disable PSR2 José Roberto de Souza
2020-05-26 22:14 ` [Intel-gfx] [PATCH 2/6] drm/i915: Add plane damage clips property José Roberto de Souza
2020-06-12 15:15 ` Mun, Gwan-gyeong
2020-06-12 15:25 ` Ville Syrjälä
2020-06-12 15:30 ` Souza, Jose
2020-06-12 15:37 ` Ville Syrjälä [this message]
2020-06-12 15:42 ` Souza, Jose
2020-05-26 22:14 ` [Intel-gfx] [PATCH 3/6] drm/i915: Reorder intel_psr2_config_valid() José Roberto de Souza
2020-06-12 15:42 ` Mun, Gwan-gyeong
2020-05-26 22:14 ` [Intel-gfx] [PATCH 4/6] drm/i915: Add PSR2 software tracking registers José Roberto de Souza
2020-06-12 20:57 ` Mun, Gwan-gyeong
2020-06-12 21:18 ` Souza, Jose
2020-06-12 21:49 ` Mun, Gwan-gyeong
2020-06-15 18:37 ` Mun, Gwan-gyeong
2020-06-15 19:23 ` Souza, Jose
2020-06-25 21:41 ` Souza, Jose
2020-05-26 22:14 ` [Intel-gfx] [PATCH 5/6] drm/i915: Implement PSR2 selective fetch José Roberto de Souza
2020-06-12 16:30 ` Ville Syrjälä
2020-06-12 20:33 ` Souza, Jose
2020-06-15 16:40 ` Ville Syrjälä
2020-06-16 15:16 ` Mun, Gwan-gyeong
2020-06-16 17:29 ` Souza, Jose
2020-06-16 20:33 ` Mun, Gwan-gyeong
2020-06-16 21:00 ` Souza, Jose
2020-05-26 22:14 ` [Intel-gfx] [PATCH 6/6] drm/i915: Implement PSR2 selective fetch WAs José Roberto de Souza
2020-05-26 22:31 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915/rkl: Disable PSR2 Patchwork
2020-05-26 22:54 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-05-27 1:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200612153756.GJ6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox