From: Greg KH <gregkh@linuxfoundation.org>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: intel-gfx@lists.freedesktop.org, stable@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/tgl: Make Wa_14010229206 permanent
Date: Fri, 19 Jun 2020 10:09:00 +0200 [thread overview]
Message-ID: <20200619080900.GD8425@kroah.com> (raw)
In-Reply-To: <20200618202701.729-1-rodrigo.vivi@intel.com>
On Thu, Jun 18, 2020 at 01:27:00PM -0700, Rodrigo Vivi wrote:
> From: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
>
> commit 63d0f3ea8ebb67160eca281320d255c72b0cb51a upstream.
>
> This workaround now applies to all steppings, not just A0.
> Wa_1409085225 is a temporary A0-only W/A however it is
> identical to Wa_14010229206 and hence the combined workaround
> is made permanent.
> Bspec: 52890
>
> Signed-off-by: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
> Tested-by: Rafael Antognolli <rafael.antognolli@intel.com>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> [mattrope: added missing blank line]
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> Link: https://patchwork.freedesktop.org/patch/msgid/20200326234955.16155-1-swathi.dhanavanthri@intel.com
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_workarounds.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
What stable kernel(s) is this backport for? You need to give us a hint
:)
thanks,
greg k-h
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> index 5176ad1a3976..092a42367851 100644
> --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
> +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
> @@ -1379,12 +1379,6 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
> GEN7_FF_THREAD_MODE,
> GEN12_FF_TESSELATION_DOP_GATE_DISABLE);
>
> - /*
> - * Wa_1409085225:tgl
> - * Wa_14010229206:tgl
> - */
> - wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN12_DISABLE_TDL_PUSH);
> -
> /* Wa_1408615072:tgl */
> wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
> VSUNIT_CLKGATE_DIS_TGL);
> @@ -1402,6 +1396,12 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
> wa_masked_en(wal,
> GEN9_CS_DEBUG_MODE1,
> FF_DOP_CLOCK_GATE_DISABLE);
> +
> + /*
> + * Wa_1409085225:tgl
> + * Wa_14010229206:tgl
> + */
> + wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN12_DISABLE_TDL_PUSH);
> }
>
> if (IS_GEN(i915, 11)) {
> --
> 2.24.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-19 8:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 20:27 [Intel-gfx] [PATCH] drm/i915/tgl: Make Wa_14010229206 permanent Rodrigo Vivi
2020-06-18 20:42 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/tgl: Make Wa_14010229206 permanent (rev2) Patchwork
2020-06-19 8:09 ` Greg KH [this message]
2020-06-19 20:14 ` [Intel-gfx] [PATCH] drm/i915/tgl: Make Wa_14010229206 permanent Rodrigo Vivi
2020-06-23 11:54 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2020-03-26 23:49 Swathi Dhanavanthri
2020-03-27 19:45 ` Rafael Antognolli
2020-04-02 22:49 ` Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200619080900.GD8425@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox