From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: remove alias to dig_port
Date: Tue, 23 Jun 2020 17:16:06 +0300 [thread overview]
Message-ID: <20200623141606.GV6112@intel.com> (raw)
In-Reply-To: <20200622232821.3093-2-lucas.demarchi@intel.com>
On Mon, Jun 22, 2020 at 04:28:20PM -0700, Lucas De Marchi wrote:
> We don't need intel_dig_port and dig_port to refer to the same thing.
> Prefer the latter.
>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index ca7bb2294d2b..58c9f3d3e7ce 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -3382,11 +3382,10 @@ static void intel_ddi_pre_enable_hdmi(struct intel_atomic_state *state,
> const struct intel_crtc_state *crtc_state,
> const struct drm_connector_state *conn_state)
> {
> - struct intel_digital_port *intel_dig_port = enc_to_dig_port(encoder);
> - struct intel_hdmi *intel_hdmi = &intel_dig_port->hdmi;
> + struct intel_digital_port *dig_port = enc_to_dig_port(encoder);
> + struct intel_hdmi *intel_hdmi = &dig_port->hdmi;
> struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
> int level = intel_ddi_hdmi_level(encoder);
> - struct intel_digital_port *dig_port = enc_to_dig_port(encoder);
>
> intel_dp_dual_mode_set_tmds_output(intel_hdmi, true);
> intel_ddi_clk_select(encoder, crtc_state);
> @@ -3413,7 +3412,7 @@ static void intel_ddi_pre_enable_hdmi(struct intel_atomic_state *state,
>
> intel_ddi_enable_pipe_clock(encoder, crtc_state);
>
> - intel_dig_port->set_infoframes(encoder,
> + dig_port->set_infoframes(encoder,
> crtc_state->has_infoframe,
> crtc_state, conn_state);
Misalinged parameters staring me in the face here. Didn't trawl the
other patch for similar since it's so big.
> }
> --
> 2.26.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-06-23 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 23:28 [Intel-gfx] [PATCH 0/2] Variable renames Lucas De Marchi
2020-06-22 23:28 ` [Intel-gfx] [PATCH 1/2] drm/i915/display: remove alias to dig_port Lucas De Marchi
2020-06-23 14:16 ` Ville Syrjälä [this message]
2020-06-23 16:58 ` Lucas De Marchi
2020-06-22 23:28 ` [Intel-gfx] [PATCH 2/2] drm/i915/display: prefer dig_port to reference intel_digital_port Lucas De Marchi
2020-06-22 23:57 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Variable renames Patchwork
2020-06-23 1:55 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200623141606.GV6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox