From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix the old vs. new epoch counter check during hotplug detect
Date: Wed, 1 Jul 2020 22:07:36 +0300 [thread overview]
Message-ID: <20200701190736.GA17127@intel.com> (raw)
In-Reply-To: <20200701180001.15857-1-imre.deak@intel.com>
On Wed, Jul 01, 2020 at 09:00:01PM +0300, Imre Deak wrote:
> The old epoch counter was left uninited, so the function returned a
> changed state always.
>
> While at it debug print the old epoch counter as well.
>
> Fixes: 35205ee9ba46 ("drm/i915: Send hotplug event if edid had changed")
> Cc: Kunal Joshi <kunal1.joshi@intel.com>
> Cc: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_hotplug.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
> index 80bcfff032e9..3f1d7b804a66 100644
> --- a/drivers/gpu/drm/i915/display/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
> @@ -288,6 +288,7 @@ intel_encoder_hotplug(struct intel_encoder *encoder,
>
> drm_WARN_ON(dev, !mutex_is_locked(&dev->mode_config.mutex));
> old_status = connector->base.status;
> + old_epoch_counter = connector->base.epoch_counter;
Yep..did it in drm_helper_hpd_irq_event but forgot here..
Thank you very much for spotting!
Reviewed-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
>
> connector->base.status =
> drm_helper_probe_detect(&connector->base, NULL, false);
> @@ -296,11 +297,12 @@ intel_encoder_hotplug(struct intel_encoder *encoder,
> ret = true;
>
> if (ret) {
> - DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s(epoch counter %llu)\n",
> + DRM_DEBUG_KMS("[CONNECTOR:%d:%s] status updated from %s to %s (epoch counter %llu->%llu)\n",
> connector->base.base.id,
> connector->base.name,
> drm_get_connector_status_name(old_status),
> drm_get_connector_status_name(connector->base.status),
> + old_epoch_counter,
> connector->base.epoch_counter);
> return INTEL_HOTPLUG_CHANGED;
> }
> --
> 2.23.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-07-01 19:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 18:00 [Intel-gfx] [PATCH] drm/i915: Fix the old vs. new epoch counter check during hotplug detect Imre Deak
2020-07-01 18:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-07-01 19:07 ` Lisovskiy, Stanislav [this message]
2020-07-02 0:24 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-07-02 7:31 ` Imre Deak
2020-07-02 8:17 ` Vudum, Lakshminarayana
2020-07-02 7:50 ` [Intel-gfx] ✓ Fi.CI.IGT: success " Patchwork
2020-07-02 8:37 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701190736.GA17127@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox