From: Yan Zhao <yan.y.zhao@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/gt:fix raw-wakeref not held calltrace in vGPU
Date: Tue, 11 Aug 2020 16:18:56 +0800 [thread overview]
Message-ID: <20200811081856.GA3605@joy-OptiPlex-7040> (raw)
In-Reply-To: <159713437103.2955.4439985576665396417@build.alporthouse.com>
On Tue, Aug 11, 2020 at 09:26:11AM +0100, Chris Wilson wrote:
> Quoting Yan Zhao (2020-08-11 04:02:09)
> > UNCORE_HAS_FORCEWAKE is not turned on when intel_vgpu_active() returns
> > true, so the guest mmio writes go to gen2_write32().
>
> The vgpu writes are just memory traps, the device wakeref should not be
> required. It seems like we've accidentally added the assert to the wrong
> io accessors.
yes. if vgpu writes de not go to gen2_write, or if gen2_write does not
need such assert, it would be better.
Thanks
Yan
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-08-11 8:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-11 3:02 [Intel-gfx] [PATCH] drm/i915/gt:fix raw-wakeref not held calltrace in vGPU Yan Zhao
2020-08-11 3:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2020-08-11 4:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-11 5:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-11 8:26 ` [Intel-gfx] [PATCH] " Chris Wilson
2020-08-11 8:18 ` Yan Zhao [this message]
2020-08-11 8:39 ` Zhenyu Wang
2020-08-11 9:25 ` [Intel-gfx] [PATCH] drm/i915: Drop runtime-pm assert from vgpu io accessors Chris Wilson
2020-08-12 2:06 ` Zhenyu Wang
2020-08-19 8:32 ` Zhenyu Wang
2020-10-19 9:37 ` Zhenyu Wang
2020-10-20 9:41 ` Chris Wilson
2020-08-11 10:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt:fix raw-wakeref not held calltrace in vGPU (rev2) Patchwork
2020-08-11 10:51 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-11 13:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200811081856.GA3605@joy-OptiPlex-7040 \
--to=yan.y.zhao@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox