Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Nischal Varide <nischal.varide@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref
Date: Thu, 20 Aug 2020 11:24:57 +0800	[thread overview]
Message-ID: <202008201129.35PcFyIc%lkp@intel.com> (raw)
In-Reply-To: <20200819043409.26010-2-nischal.varide@intel.com>

Hi Nischal,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v5.9-rc1 next-20200819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck warnings: (new ones prefixed by >>)

        ^
   drivers/gpu/drm/i915/display/intel_display.c:4308:7: warning: Local variable src_w shadows outer variable [shadowVar]
     int src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
         ^
   drivers/gpu/drm/i915/display/intel_display.c:4271:20: note: Shadowed declaration
    int src_x, src_y, src_w;
                      ^
   drivers/gpu/drm/i915/display/intel_display.c:4308:7: note: Shadow variable
     int src_w = drm_rect_width(&plane_state->uapi.src) >> 16;
         ^
   drivers/gpu/drm/i915/display/intel_display.c:11169:7: warning: Local variable tmp shadows outer variable [shadowVar]
     u32 tmp = intel_de_read(dev_priv,
         ^
   drivers/gpu/drm/i915/display/intel_display.c:11133:6: note: Shadowed declaration
    u32 tmp;
        ^
   drivers/gpu/drm/i915/display/intel_display.c:11169:7: note: Shadow variable
     u32 tmp = intel_de_read(dev_priv,
         ^
   drivers/gpu/drm/i915/display/intel_display.c:14246:4: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
      I915_STATE_WARN(active,
      ^
   drivers/gpu/drm/i915/display/intel_display.c:14237:3: note: Shadowed declaration
     I915_STATE_WARN(!!encoder->base.crtc != enabled,
     ^
   drivers/gpu/drm/i915/display/intel_display.c:14246:4: note: Shadow variable
      I915_STATE_WARN(active,
      ^
   drivers/gpu/drm/i915/display/intel_display.c:14293:3: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
     I915_STATE_WARN(active != new_crtc_state->hw.active,
     ^
   drivers/gpu/drm/i915/display/intel_display.c:14279:2: note: Shadowed declaration
    I915_STATE_WARN(new_crtc_state->hw.active != active,
    ^
   drivers/gpu/drm/i915/display/intel_display.c:14293:3: note: Shadow variable
     I915_STATE_WARN(active != new_crtc_state->hw.active,
     ^
   drivers/gpu/drm/i915/display/intel_display.c:14298:3: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
     I915_STATE_WARN(active && crtc->pipe != pipe,
     ^
   drivers/gpu/drm/i915/display/intel_display.c:14279:2: note: Shadowed declaration
    I915_STATE_WARN(new_crtc_state->hw.active != active,
    ^
   drivers/gpu/drm/i915/display/intel_display.c:14298:3: note: Shadow variable
     I915_STATE_WARN(active && crtc->pipe != pipe,
     ^
   drivers/gpu/drm/i915/display/intel_display.c:14315:3: warning: Local variable __ret_warn_on shadows outer variable [shadowVar]
     I915_STATE_WARN(1, "pipe state doesn't match!n");
     ^
   drivers/gpu/drm/i915/display/intel_display.c:14279:2: note: Shadowed declaration
    I915_STATE_WARN(new_crtc_state->hw.active != active,
    ^
   drivers/gpu/drm/i915/display/intel_display.c:14315:3: note: Shadow variable
     I915_STATE_WARN(1, "pipe state doesn't match!n");
     ^
   drivers/gpu/drm/i915/display/intel_display.c:18447:23: warning: Local variable crtc shadows outer variable [shadowVar]
      struct intel_crtc *crtc;
                         ^
   drivers/gpu/drm/i915/display/intel_display.c:18385:21: note: Shadowed declaration
    struct intel_crtc *crtc;
                       ^
   drivers/gpu/drm/i915/display/intel_display.c:18447:23: note: Shadow variable
      struct intel_crtc *crtc;
                         ^
   drivers/gpu/drm/i915/display/intel_display.c:6103:35: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
    scaler_state->scaler_users |= (1 << scaler_user);
                                     ^
   drivers/gpu/drm/i915/display/intel_display.c:6127:6: note: Calling function 'skl_update_scaler', 3rd argument '31' value is 31
        SKL_CRTC_INDEX,
        ^
   drivers/gpu/drm/i915/display/intel_display.c:6103:35: note: Shift
    scaler_state->scaler_users |= (1 << scaler_user);
                                     ^
   drivers/gpu/drm/i915/display/intel_display.c:10477:36: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
     scaler_state->scaler_users |= (1 << SKL_CRTC_INDEX);
                                      ^
   drivers/gpu/drm/i915/display/intel_display.c:10479:37: warning: Shifting signed 32-bit value by 31 bits is undefined behaviour [shiftTooManyBitsSigned]
     scaler_state->scaler_users &= ~(1 << SKL_CRTC_INDEX);
                                       ^
>> drivers/gpu/drm/i915/display/intel_display.c:11280:9: warning: Uninitialized variable: base [uninitvar]
    return base + plane_state->color_plane[0].offset;
           ^

# https://github.com/0day-ci/linux/commit/5d862961b8571914f726e947570316016ec67c5d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Nischal-Varide/Critical-KclockWork-Fixes-intel_atomi-c-PossibleNull/20200819-193249
git checkout 5d862961b8571914f726e947570316016ec67c5d
vim +11280 drivers/gpu/drm/i915/display/intel_display.c

0e8ffe1bf81b07 drivers/gpu/drm/i915/intel_display.c         Daniel Vetter         2013-03-28  11263  
cd5dcbf1b26c60 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11264  static u32 intel_cursor_base(const struct intel_plane_state *plane_state)
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11265  {
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11266  	struct drm_i915_private *dev_priv =
f90a85e76c2a89 drivers/gpu/drm/i915/display/intel_display.c Maarten Lankhorst     2019-10-31  11267  		to_i915(plane_state->uapi.plane->dev);
7b3cb17a48dc1b drivers/gpu/drm/i915/display/intel_display.c Maarten Lankhorst     2019-10-31  11268  	const struct drm_framebuffer *fb = plane_state->hw.fb;
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11269  	const struct drm_i915_gem_object *obj = intel_fb_obj(fb);
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11270  	u32 base;
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11271  
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide        2020-08-19  11272  	if (obj) {
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide        2020-08-19  11273  
d53db442db36fd drivers/gpu/drm/i915/intel_display.c         José Roberto de Souza 2018-11-30  11274  		if (INTEL_INFO(dev_priv)->display.cursor_needs_physical)
c6790dc22312f5 drivers/gpu/drm/i915/display/intel_display.c Chris Wilson          2020-02-02  11275  			base = sg_dma_address(obj->mm.pages->sgl);
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11276  		else
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11277  			base = intel_plane_ggtt_offset(plane_state);
5d862961b85719 drivers/gpu/drm/i915/display/intel_display.c Nischal Varide        2020-08-19  11278  	}
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11279  
30a027dcccc270 drivers/gpu/drm/i915/display/intel_display.c Ville Syrjälä         2019-10-15 @11280  	return base + plane_state->color_plane[0].offset;
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11281  }
1cecc830e6b662 drivers/gpu/drm/i915/intel_display.c         Ville Syrjälä         2017-03-27  11282  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-08-20  3:25 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-19  4:34 [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Nischal Varide
2020-08-19  4:34 ` [Intel-gfx] [PATCH 2/5] Critical-KlockWork-Fixes-intel_display.c-NullDeref Nischal Varide
2020-08-20  3:24   ` kernel test robot [this message]
2020-08-25  9:25   ` Dan Carpenter
2020-08-19  4:34 ` [Intel-gfx] [PATCH 3/5] Critical-KlockWorks-Fix-intel_sdvo.c-Possible-Null Nischal Varide
2020-08-19  4:34 ` [Intel-gfx] [PATCH 4/5] Critical-KlockWork-Fix-intel_tv.c-Possible-Null Nischal Varide
2020-08-24  6:32   ` Anshuman Gupta
2020-08-25  9:31   ` Dan Carpenter
2020-08-19  4:34 ` [Intel-gfx] [PATCH 5/5] Critical-KlockWorks-Fix-intel_crt.c-Possible-Null Nischal Varide
2020-08-24  6:27   ` Anshuman Gupta
2020-08-19 11:52 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Patchwork
2020-08-19 12:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-19 18:47 ` [Intel-gfx] [PATCH 1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull kernel test robot
2020-08-19 18:47 ` [Intel-gfx] [PATCH] fix boolreturn.cocci warnings kernel test robot
2020-08-19 22:37 ` [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] Critical-KclockWork-Fixes-intel_atomi.c-PossibleNull Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202008201129.35PcFyIc%lkp@intel.com \
    --to=lkp@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kbuild-all@lists.01.org \
    --cc=nischal.varide@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox