From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Nischal Varide <nischal.varide@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 1/5] Fixing Possible Null Pointer Dereference
Date: Mon, 24 Aug 2020 22:58:57 +0300 [thread overview]
Message-ID: <20200824195857.GK6112@intel.com> (raw)
In-Reply-To: <20200824034556.26626-1-nischal.varide@intel.com>
On Mon, Aug 24, 2020 at 09:15:52AM +0530, Nischal Varide wrote:
> There is a possble Null Pointer dereference in intel_atomic.c and this
> patch fixes the same by introducting a check to old_state, new_state
> old_conn_state and new_conn_state variables.
Not possible. In fact none of the supposed null ptrs in the series
seem possible to me.
>
> Signed-off-by: Nischal Varide <nischal.varide@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_atomic.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
> index 630f49b7aa01..ab58f061c8a7 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic.c
> @@ -132,6 +132,9 @@ int intel_digital_connector_atomic_check(struct drm_connector *conn,
> to_intel_digital_connector_state(old_state);
> struct drm_crtc_state *crtc_state;
>
> + if (!(new_state && new_conn_state && old_state && old_conn_state))
> + return 0;
> +
> intel_hdcp_atomic_check(conn, old_state, new_state);
> intel_psr_atomic_check(conn, old_state, new_state);
>
> @@ -192,6 +195,8 @@ intel_connector_needs_modeset(struct intel_atomic_state *state,
>
> old_conn_state = drm_atomic_get_old_connector_state(&state->base, connector);
> new_conn_state = drm_atomic_get_new_connector_state(&state->base, connector);
> + if (!(old_conn_state && new_conn_state))
> + return 0;
>
> return old_conn_state->crtc != new_conn_state->crtc ||
> (new_conn_state->crtc &&
> --
> 2.26.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-08-24 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 3:45 [Intel-gfx] [PATCH 1/5] Fixing Possible Null Pointer Dereference Nischal Varide
2020-08-24 3:45 ` [Intel-gfx] [PATCH 2/5] " Nischal Varide
2020-08-24 3:45 ` [Intel-gfx] [PATCH 3/5] Fixing a " Nischal Varide
2020-08-24 3:45 ` [Intel-gfx] [PATCH 4/5] Fixing " Nischal Varide
2020-08-24 3:45 ` [Intel-gfx] [PATCH 5/5] Fixing a " Nischal Varide
2020-08-24 10:51 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] Fixing " Patchwork
2020-08-24 11:08 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-08-24 14:06 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-08-24 19:58 ` Ville Syrjälä [this message]
2020-08-27 6:49 ` [Intel-gfx] [PATCH 1/5] " Shankar, Uma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200824195857.GK6112@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nischal.varide@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox