From: Anshuman Gupta <anshuman.gupta@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org,
Hariom Pandey <hariom.pandey@intel.com>,
Srinivas K <srinivasx.k@intel.com>
Subject: Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/display: Fix DRRS debugfs
Date: Tue, 25 Aug 2020 11:11:32 +0530 [thread overview]
Message-ID: <20200825054131.GG25390@intel.com> (raw)
In-Reply-To: <20200824174345.87553-3-jose.souza@intel.com>
On 2020-08-24 at 10:43:45 -0700, José Roberto de Souza wrote:
> Supported and enabled are different things so printing both.
>
> Cc: Anshuman Gupta <anshuman.gupta@intel.com>
> Cc: Srinivas K <srinivasx.k@intel.com>
> Cc: Hariom Pandey <hariom.pandey@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display_debugfs.c | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index f549381048b3..4b4cabf34d24 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -1069,10 +1069,18 @@ static void drrs_status_per_crtc(struct seq_file *m,
>
> drm_connector_list_iter_begin(dev, &conn_iter);
> drm_for_each_connector_iter(connector, &conn_iter) {
> + bool supported = false;
> +
> if (connector->state->crtc != &intel_crtc->base)
> continue;
>
> seq_printf(m, "%s:\n", connector->name);
> +
> + if (connector->connector_type == DRM_MODE_CONNECTOR_eDP &&
> + dev_priv->vbt.drrs_type == SEAMLESS_DRRS_SUPPORT)
IMO use dev_priv->drrs.type here, becuase DRRS is not supported in case
intel_panel_edid_downclock_mode() return a NULL downclock mode in
intel_dp_drrs_init().
Thanks,
Anshuman Gupta
> + supported = true;
> +
> + seq_printf(m, "\tDRRS Supported: %s\n", yesno(supported));
> }
> drm_connector_list_iter_end(&conn_iter);
>
> @@ -1083,7 +1091,7 @@ static void drrs_status_per_crtc(struct seq_file *m,
>
> mutex_lock(&drrs->mutex);
> /* DRRS Supported */
> - seq_puts(m, "\tDRRS Supported: Yes\n");
> + seq_puts(m, "\tDRRS Enabled: Yes\n");
>
> /* disable_drrs() will make drrs->dp NULL */
> if (!drrs->dp) {
> @@ -1118,7 +1126,7 @@ static void drrs_status_per_crtc(struct seq_file *m,
> mutex_unlock(&drrs->mutex);
> } else {
> /* DRRS not supported. Print the VBT parameter*/
> - seq_puts(m, "\tDRRS Supported : No");
> + seq_puts(m, "\tDRRS Enabled : No");
> }
> seq_puts(m, "\n");
> }
> --
> 2.28.0
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-08-25 5:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 17:43 [Intel-gfx] [PATCH v2 1/3] drm/i915/display: Compute has_drrs after compute has_psr José Roberto de Souza
2020-08-24 17:43 ` [Intel-gfx] [PATCH v2 2/3] drm/i915/display: Disable DRRS when needed in fastsets José Roberto de Souza
2020-08-24 17:43 ` [Intel-gfx] [PATCH v2 3/3] drm/i915/display: Fix DRRS debugfs José Roberto de Souza
2020-08-25 5:41 ` Anshuman Gupta [this message]
2020-08-24 19:29 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/3] drm/i915/display: Compute has_drrs after compute has_psr Patchwork
2020-08-25 1:03 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200825054131.GG25390@intel.com \
--to=anshuman.gupta@intel.com \
--cc=hariom.pandey@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
--cc=srinivasx.k@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox