From: Imre Deak <imre.deak@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH 3/3] drm/i915: s/int/u32/ for aux_offset/alignment
Date: Thu, 8 Oct 2020 16:41:07 +0300 [thread overview]
Message-ID: <20201008134107.GC1784305@ideak-desk.fi.intel.com> (raw)
In-Reply-To: <20201008101608.8652-3-ville.syrjala@linux.intel.com>
On Thu, Oct 08, 2020 at 01:16:08PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> ggtt offsets/alignments are u32 everywhere else. Don't use
> a signed int for them here.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 34ba34f84b2a..fe482ca721f8 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -4026,8 +4026,8 @@ static int skl_check_nv12_aux_surface(struct intel_plane_state *plane_state)
>
> if (is_ccs_modifier(fb->modifier)) {
> int ccs_plane = main_to_ccs_plane(fb, uv_plane);
> - int aux_offset = plane_state->color_plane[ccs_plane].offset;
> - int alignment = intel_surf_alignment(fb, uv_plane);
> + u32 aux_offset = plane_state->color_plane[ccs_plane].offset;
> + u32 alignment = intel_surf_alignment(fb, uv_plane);
>
> if (offset > aux_offset)
> offset = intel_plane_adjust_aligned_offset(&x, &y,
> --
> 2.26.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-10-08 13:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 10:16 [Intel-gfx] [PATCH 1/3] drm/i915: Set all unused color plane offsets to ~0xfff again Ville Syrjala
2020-10-08 10:16 ` [Intel-gfx] [PATCH 2/3] drm/i915: Skip aux plane stuff when there is no aux plane Ville Syrjala
2020-10-08 13:38 ` Imre Deak
2020-10-09 12:00 ` [Intel-gfx] [PATCH v2 " Ville Syrjala
2020-10-08 10:16 ` [Intel-gfx] [PATCH 3/3] drm/i915: s/int/u32/ for aux_offset/alignment Ville Syrjala
2020-10-08 13:41 ` Imre Deak [this message]
2020-10-08 12:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Set all unused color plane offsets to ~0xfff again Patchwork
2020-10-08 13:23 ` [Intel-gfx] [PATCH 1/3] " Imre Deak
2020-10-08 16:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Set all unused color plane offsets to ~0xfff again (rev2) Patchwork
2020-10-09 12:28 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Set all unused color plane offsets to ~0xfff again (rev4) Patchwork
2020-10-09 15:45 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201008134107.GC1784305@ideak-desk.fi.intel.com \
--to=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox