From: Kamati Srinivas <srinivasx.k@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: seanpaul@chromium.org, hariom.pandey@intel.com
Subject: [Intel-gfx] drm/i915: Acquire connector reference before prop_work
Date: Tue, 27 Oct 2020 16:03:35 +0530 [thread overview]
Message-ID: <20201027103335.3725-1-srinivasx.k@intel.com> (raw)
From: Srinivas Kamati <srinivasx.k@intel.com>
"Content protection type change" igt test results in kernel
taint. Everytime after prop_work is done we are also
giving up connector reference, which is resulting in ref
count underrun.
Before scheduling prop_work acquire connector reference.
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Ramalingam C <ramalingam.c@intel.com>
Signed-off-by: Srinivas Kamati <srinivasx.k@intel.com>
---
drivers/gpu/drm/i915/display/intel_hdcp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/display/intel_hdcp.c b/drivers/gpu/drm/i915/display/intel_hdcp.c
index b2a4bbcfdcd2..beedd672b21e 100644
--- a/drivers/gpu/drm/i915/display/intel_hdcp.c
+++ b/drivers/gpu/drm/i915/display/intel_hdcp.c
@@ -2210,6 +2210,7 @@ void intel_hdcp_update_pipe(struct intel_atomic_state *state,
if (content_protection_type_changed) {
mutex_lock(&hdcp->mutex);
hdcp->value = DRM_MODE_CONTENT_PROTECTION_DESIRED;
+ drm_connector_get(&connector->base);
schedule_work(&hdcp->prop_work);
mutex_unlock(&hdcp->mutex);
}
--
2.25.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2020-10-27 10:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 10:33 Kamati Srinivas [this message]
2020-10-28 1:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Acquire connector reference before prop_work Patchwork
2020-10-28 4:08 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-28 9:04 ` [Intel-gfx] " Anshuman Gupta
2020-10-28 9:22 ` K, SrinivasX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027103335.3725-1-srinivasx.k@intel.com \
--to=srinivasx.k@intel.com \
--cc=hariom.pandey@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox