Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Peilin Ye <yepeilin.cs@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Daniel Vetter <daniel.vetter@intel.com>,
	Jiri Slaby <jirislaby@kernel.org>, Helge Deller <deller@gmx.de>
Subject: [Intel-gfx] [PATCH 2/3] fbcon: Drop EXPORT_SYMBOL
Date: Thu, 29 Oct 2020 11:14:27 +0100	[thread overview]
Message-ID: <20201029101428.4058311-2-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <20201029101428.4058311-1-daniel.vetter@ffwll.ch>

Every since

commit 6104c37094e729f3d4ce65797002112735d49cd1
Author: Daniel Vetter <daniel.vetter@ffwll.ch>
Date:   Tue Aug 1 17:32:07 2017 +0200

    fbcon: Make fbcon a built-time depency for fbdev

these are no longer distinct loadable modules, so exporting symbols is
kinda pointless.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Helge Deller <deller@gmx.de>
Cc: Peilin Ye <yepeilin.cs@gmail.com>
---
 drivers/video/fbdev/core/bitblit.c      | 3 ---
 drivers/video/fbdev/core/fbcon_ccw.c    | 1 -
 drivers/video/fbdev/core/fbcon_cw.c     | 1 -
 drivers/video/fbdev/core/fbcon_rotate.c | 1 -
 drivers/video/fbdev/core/fbcon_ud.c     | 1 -
 drivers/video/fbdev/core/softcursor.c   | 2 --
 drivers/video/fbdev/core/tileblit.c     | 2 --
 7 files changed, 11 deletions(-)

diff --git a/drivers/video/fbdev/core/bitblit.c b/drivers/video/fbdev/core/bitblit.c
index 9725ecd1255b..f98e8f298bc1 100644
--- a/drivers/video/fbdev/core/bitblit.c
+++ b/drivers/video/fbdev/core/bitblit.c
@@ -404,6 +404,3 @@ void fbcon_set_bitops(struct fbcon_ops *ops)
 	if (ops->rotate)
 		fbcon_set_rotate(ops);
 }
-
-EXPORT_SYMBOL(fbcon_set_bitops);
-
diff --git a/drivers/video/fbdev/core/fbcon_ccw.c b/drivers/video/fbdev/core/fbcon_ccw.c
index bbd869efd03b..9cd2c4b05c32 100644
--- a/drivers/video/fbdev/core/fbcon_ccw.c
+++ b/drivers/video/fbdev/core/fbcon_ccw.c
@@ -409,4 +409,3 @@ void fbcon_rotate_ccw(struct fbcon_ops *ops)
 	ops->cursor = ccw_cursor;
 	ops->update_start = ccw_update_start;
 }
-EXPORT_SYMBOL(fbcon_rotate_ccw);
diff --git a/drivers/video/fbdev/core/fbcon_cw.c b/drivers/video/fbdev/core/fbcon_cw.c
index a34cbe8e9874..88d89fad3f05 100644
--- a/drivers/video/fbdev/core/fbcon_cw.c
+++ b/drivers/video/fbdev/core/fbcon_cw.c
@@ -392,4 +392,3 @@ void fbcon_rotate_cw(struct fbcon_ops *ops)
 	ops->cursor = cw_cursor;
 	ops->update_start = cw_update_start;
 }
-EXPORT_SYMBOL(fbcon_rotate_cw);
diff --git a/drivers/video/fbdev/core/fbcon_rotate.c b/drivers/video/fbdev/core/fbcon_rotate.c
index ac72d4f85f7d..df6b469aa2c2 100644
--- a/drivers/video/fbdev/core/fbcon_rotate.c
+++ b/drivers/video/fbdev/core/fbcon_rotate.c
@@ -110,4 +110,3 @@ void fbcon_set_rotate(struct fbcon_ops *ops)
 		break;
 	}
 }
-EXPORT_SYMBOL(fbcon_set_rotate);
diff --git a/drivers/video/fbdev/core/fbcon_ud.c b/drivers/video/fbdev/core/fbcon_ud.c
index 199cbc7abe35..8d5e66b1bdfb 100644
--- a/drivers/video/fbdev/core/fbcon_ud.c
+++ b/drivers/video/fbdev/core/fbcon_ud.c
@@ -436,4 +436,3 @@ void fbcon_rotate_ud(struct fbcon_ops *ops)
 	ops->cursor = ud_cursor;
 	ops->update_start = ud_update_start;
 }
-EXPORT_SYMBOL(fbcon_rotate_ud);
diff --git a/drivers/video/fbdev/core/softcursor.c b/drivers/video/fbdev/core/softcursor.c
index fc93f254498e..29e5b21cf373 100644
--- a/drivers/video/fbdev/core/softcursor.c
+++ b/drivers/video/fbdev/core/softcursor.c
@@ -74,5 +74,3 @@ int soft_cursor(struct fb_info *info, struct fb_cursor *cursor)
 	info->fbops->fb_imageblit(info, image);
 	return 0;
 }
-
-EXPORT_SYMBOL(soft_cursor);
diff --git a/drivers/video/fbdev/core/tileblit.c b/drivers/video/fbdev/core/tileblit.c
index 628fe5e010c0..7539ae9040f8 100644
--- a/drivers/video/fbdev/core/tileblit.c
+++ b/drivers/video/fbdev/core/tileblit.c
@@ -151,5 +151,3 @@ void fbcon_set_tileops(struct vc_data *vc, struct fb_info *info)
 		info->tileops->fb_settile(info, &map);
 	}
 }
-
-EXPORT_SYMBOL(fbcon_set_tileops);
-- 
2.28.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-10-29 10:14 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-29 10:14 [Intel-gfx] [PATCH 1/3] fbcon: Disable accelerated scrolling Daniel Vetter
2020-10-29 10:14 ` Daniel Vetter [this message]
2020-10-29 19:15   ` [Intel-gfx] [PATCH 2/3] fbcon: Drop EXPORT_SYMBOL Thomas Zimmermann
2020-10-29 10:14 ` [Intel-gfx] [PATCH 3/3] drm/qxl: Remove fbcon acceleration leftovers Daniel Vetter
2020-10-29 11:13   ` Gerd Hoffmann
2020-10-29 13:33   ` [Intel-gfx] [PATCH] " Daniel Vetter
2020-11-17 10:01     ` Daniel Vetter
2020-10-29 13:56   ` [Intel-gfx] [PATCH 3/3] " kernel test robot
2020-10-30  0:37   ` kernel test robot
2020-10-29 11:23 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] fbcon: Disable accelerated scrolling Patchwork
2020-10-29 11:53 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-10-29 12:42 ` [Intel-gfx] [PATCH 1/3] " kernel test robot
2020-10-29 13:22 ` [Intel-gfx] [PATCH] " Daniel Vetter
2020-10-30  8:30   ` Tomi Valkeinen
2020-10-30  8:52     ` Daniel Vetter
2020-10-31 10:27   ` Geert Uytterhoeven
2020-10-31 14:17     ` Daniel Vetter
2020-11-18  9:21       ` Geert Uytterhoeven
2020-10-29 13:29 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with fbcon: Disable accelerated scrolling (rev2) Patchwork
2020-10-29 14:07 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/3] fbcon: Disable accelerated scrolling Patchwork
2020-10-29 14:09 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with fbcon: Disable accelerated scrolling (rev2) Patchwork
2020-10-29 14:43 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with fbcon: Disable accelerated scrolling (rev3) Patchwork
2020-10-29 15:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-10-29 17:27 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-29 19:17 ` [Intel-gfx] [PATCH 1/3] fbcon: Disable accelerated scrolling Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201029101428.4058311-2-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jirislaby@kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=yepeilin.cs@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox