From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, Intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 5/5] intel_gpu_top: Default GPU list to PCI mode
Date: Mon, 16 Nov 2020 19:40:50 +0100 [thread overview]
Message-ID: <20201116184050.GA9090@zkempczy-mobl2> (raw)
In-Reply-To: <20201116172653.4030093-5-tvrtko.ursulin@linux.intel.com>
On Mon, Nov 16, 2020 at 05:26:53PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> It is more obvious for the user to only shows filters for DRM master
> nodes since those are the ones that intel_gpu_top monitors.
>
> v2:
> * Filter prefix needs to be sys: when listing PCI devices.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> tools/intel_gpu_top.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 07f88d555dc8..37b2141e784d 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1388,7 +1388,8 @@ int main(int argc, char **argv)
>
> if (list_device) {
> struct igt_devices_print_format fmt = {
> - .type = IGT_PRINT_USER
> + .type = IGT_PRINT_USER,
> + .option = IGT_PRINT_PCI,
> };
>
> igt_devices_print(&fmt);
> --
> 2.25.1
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
Looks ok.
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2020-11-16 18:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 17:26 [Intel-gfx] [PATCH i-g-t 1/5] intel_gpu_top: User friendly device listing Tvrtko Ursulin
2020-11-16 17:26 ` [Intel-gfx] [PATCH i-g-t 2/5] lsgpu: " Tvrtko Ursulin
2020-11-16 17:26 ` [Intel-gfx] [PATCH i-g-t 3/5] lib/igt_device_scan: Remember PCI card index after scanning Tvrtko Ursulin
2020-11-16 17:58 ` Zbigniew Kempczyński
2020-11-16 17:26 ` [Intel-gfx] [PATCH i-g-t 4/5] lsgpu: Add filter type print-out selection Tvrtko Ursulin
2020-11-16 18:45 ` Zbigniew Kempczyński
2020-11-16 17:26 ` [Intel-gfx] [PATCH i-g-t 5/5] intel_gpu_top: Default GPU list to PCI mode Tvrtko Ursulin
2020-11-16 18:40 ` Zbigniew Kempczyński [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116184050.GA9090@zkempczy-mobl2 \
--to=zbigniew.kempczynski@intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox