Re: [Intel-gfx] [PATCH] drm/i915/tgl: Fix REVID macros for TGL to fetch correct stepping

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5264 bytes --]

Hi Aditya,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip v5.10-rc5 next-20201124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Aditya-Swarup/drm-i915-tgl-Fix-REVID-macros-for-TGL-to-fetch-correct-stepping/20201125-083215
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a004-20201125 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/ce4e72969ddaa07dd8426d230d04ed91382e2fd9
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aditya-Swarup/drm-i915-tgl-Fix-REVID-macros-for-TGL-to-fetch-correct-stepping/20201125-083215
        git checkout ce4e72969ddaa07dd8426d230d04ed91382e2fd9
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/drm/drm_mm.h:49,
                    from include/drm/drm_vma_manager.h:26,
                    from include/drm/drm_gem.h:40,
                    from drivers/gpu/drm/i915/i915_drv.h:55,
                    from drivers/gpu/drm/i915/gt/intel_workarounds.c:7:
   drivers/gpu/drm/i915/i915_drv.h: In function 'tgl_revids_get':
>> drivers/gpu/drm/i915/i915_drv.h:1594:9: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=]
    1594 |         "Unsupported SOC stepping found %u, using %lu instead\n",
         |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/drm/drm_print.h:450:38: note: in definition of macro 'drm_dbg_kms'
     450 |  drm_dev_dbg((drm)->dev, DRM_UT_KMS, fmt, ##__VA_ARGS__)
         |                                      ^~~
   In file included from drivers/gpu/drm/i915/gt/intel_workarounds.c:7:
   drivers/gpu/drm/i915/i915_drv.h:1594:53: note: format string is defined here
    1594 |         "Unsupported SOC stepping found %u, using %lu instead\n",
         |                                                   ~~^
         |                                                     |
         |                                                     long unsigned int
         |                                                   %u
   In file included from include/drm/drm_mm.h:49,
                    from include/drm/drm_vma_manager.h:26,
                    from include/drm/drm_gem.h:40,
                    from drivers/gpu/drm/i915/i915_drv.h:55,
                    from drivers/gpu/drm/i915/gt/intel_workarounds.c:7:
   drivers/gpu/drm/i915/i915_drv.h:1602:8: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'unsigned int' [-Wformat=]
    1602 |        "Unsupported SOC stepping found %u, using %lu instead\n",
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/drm/drm_print.h:450:38: note: in definition of macro 'drm_dbg_kms'
     450 |  drm_dev_dbg((drm)->dev, DRM_UT_KMS, fmt, ##__VA_ARGS__)
         |                                      ^~~
   In file included from drivers/gpu/drm/i915/gt/intel_workarounds.c:7:
   drivers/gpu/drm/i915/i915_drv.h:1602:52: note: format string is defined here
    1602 |        "Unsupported SOC stepping found %u, using %lu instead\n",
         |                                                  ~~^
         |                                                    |
         |                                                    long unsigned int
         |                                                  %u

vim +1594 drivers/gpu/drm/i915/i915_drv.h

  1577	
  1578	#define TGL_UY_REVID_RANGE(revid) \
  1579		((revid) < ARRAY_SIZE(tgl_uy_revids))
  1580	
  1581	#define TGL_REVID_RANGE(revid) \
  1582		((revid) < ARRAY_SIZE(tgl_revids))
  1583	
  1584	static inline const struct i915_rev_steppings *
  1585	tgl_revids_get(struct drm_i915_private *dev_priv)
  1586	{
  1587		const u8 revid = INTEL_REVID(dev_priv);
  1588	
  1589		if (IS_TGL_U(dev_priv) || IS_TGL_Y(dev_priv)) {
  1590			if (TGL_UY_REVID_RANGE(revid)) {
  1591				return tgl_uy_revids + revid;
  1592			} else {
  1593				drm_dbg_kms(&dev_priv->drm,
> 1594					    "Unsupported SOC stepping found %u, using %lu instead\n",
  1595					    revid, ARRAY_SIZE(tgl_uy_revids) - 1);
  1596				return tgl_uy_revids + (ARRAY_SIZE(tgl_uy_revids) - 1);
  1597			}
  1598		} else if (TGL_REVID_RANGE(revid)) {
  1599			return tgl_revids + revid;
  1600		} else	{
  1601			drm_dbg_kms(&dev_priv->drm,
  1602				    "Unsupported SOC stepping found %u, using %lu instead\n",
  1603				    revid, ARRAY_SIZE(tgl_revids) - 1);
  1604			return tgl_uy_revids + (ARRAY_SIZE(tgl_revids) - 1);
  1605		}
  1606	}
  1607	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37654 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx