From: Thomas Zimmermann <tzimmermann@suse.de>
To: airlied@linux.ie, daniel@ffwll.ch
Cc: Sam Ravnborg <sam@ravnborg.org>,
Xinliang Liu <xinliang.liu@linaro.org>,
nouveau@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
Xinwei Kong <kong.kongxinwei@hisilicon.com>,
John Stultz <john.stultz@linaro.org>,
amd-gfx@lists.freedesktop.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Tian Tao <tiantao6@hisilicon.com>,
spice-devel@lists.freedesktop.org,
intel-gvt-dev@lists.freedesktop.org,
Chen Feng <puck.chen@hisilicon.com>
Subject: [Intel-gfx] [PATCH v2 08/20] drm/hibmc: Remove references to struct drm_device.pdev
Date: Tue, 1 Dec 2020 11:35:30 +0100 [thread overview]
Message-ID: <20201201103542.2182-9-tzimmermann@suse.de> (raw)
In-Reply-To: <20201201103542.2182-1-tzimmermann@suse.de>
Using struct drm_device.pdev is deprecated. Convert hibmc to struct
drm_device.dev. No functional changes.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Xinliang Liu <xinliang.liu@linaro.org>
Cc: Tian Tao <tiantao6@hisilicon.com>
Cc: John Stultz <john.stultz@linaro.org>
Cc: Xinwei Kong <kong.kongxinwei@hisilicon.com>
Cc: Chen Feng <puck.chen@hisilicon.com>
---
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 10 +++++-----
drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c | 2 +-
drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c | 4 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
index d845657fd99c..ac5868343d0c 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c
@@ -203,7 +203,7 @@ static void hibmc_hw_config(struct hibmc_drm_private *priv)
static int hibmc_hw_map(struct hibmc_drm_private *priv)
{
struct drm_device *dev = priv->dev;
- struct pci_dev *pdev = dev->pdev;
+ struct pci_dev *pdev = to_pci_dev(dev->dev);
resource_size_t addr, size, ioaddr, iosize;
ioaddr = pci_resource_start(pdev, 1);
@@ -249,7 +249,7 @@ static int hibmc_unload(struct drm_device *dev)
if (dev->irq_enabled)
drm_irq_uninstall(dev);
- pci_disable_msi(dev->pdev);
+ pci_disable_msi(to_pci_dev(dev->dev));
hibmc_kms_fini(priv);
hibmc_mm_fini(priv);
dev->dev_private = NULL;
@@ -258,6 +258,7 @@ static int hibmc_unload(struct drm_device *dev)
static int hibmc_load(struct drm_device *dev)
{
+ struct pci_dev *pdev = to_pci_dev(dev->dev);
struct hibmc_drm_private *priv;
int ret;
@@ -287,11 +288,11 @@ static int hibmc_load(struct drm_device *dev)
goto err;
}
- ret = pci_enable_msi(dev->pdev);
+ ret = pci_enable_msi(pdev);
if (ret) {
drm_warn(dev, "enabling MSI failed: %d\n", ret);
} else {
- ret = drm_irq_install(dev, dev->pdev->irq);
+ ret = drm_irq_install(dev, pdev->irq);
if (ret)
drm_warn(dev, "install irq failed: %d\n", ret);
}
@@ -324,7 +325,6 @@ static int hibmc_pci_probe(struct pci_dev *pdev,
return PTR_ERR(dev);
}
- dev->pdev = pdev;
pci_set_drvdata(pdev, dev);
ret = pci_enable_device(pdev);
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c
index 86d712090d87..410bd019bb35 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c
@@ -83,7 +83,7 @@ int hibmc_ddc_create(struct drm_device *drm_dev,
connector->adapter.owner = THIS_MODULE;
connector->adapter.class = I2C_CLASS_DDC;
snprintf(connector->adapter.name, I2C_NAME_SIZE, "HIS i2c bit bus");
- connector->adapter.dev.parent = &drm_dev->pdev->dev;
+ connector->adapter.dev.parent = drm_dev->dev;
i2c_set_adapdata(&connector->adapter, connector);
connector->adapter.algo_data = &connector->bit_data;
diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
index 602ece11bb4a..77f075075db2 100644
--- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
+++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_ttm.c
@@ -26,9 +26,9 @@ int hibmc_mm_init(struct hibmc_drm_private *hibmc)
struct drm_vram_mm *vmm;
int ret;
struct drm_device *dev = hibmc->dev;
+ struct pci_dev *pdev = to_pci_dev(dev->dev);
- vmm = drm_vram_helper_alloc_mm(dev,
- pci_resource_start(dev->pdev, 0),
+ vmm = drm_vram_helper_alloc_mm(dev, pci_resource_start(pdev, 0),
hibmc->fb_size);
if (IS_ERR(vmm)) {
ret = PTR_ERR(vmm);
--
2.29.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-12-01 10:36 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 10:35 [Intel-gfx] [PATCH v2 00/20] drm: Move struct drm_device.pdev to legacy Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 01/20] drm/amdgpu: Fix trailing whitespaces Thomas Zimmermann
2020-12-01 10:40 ` Christian König
2020-12-02 7:59 ` Thomas Zimmermann
2020-12-02 8:43 ` Christian König
2020-12-02 8:52 ` Thomas Zimmermann
2020-12-02 14:02 ` Alex Deucher
2020-12-02 14:28 ` Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 02/20] drm/amdgpu: Remove references to struct drm_device.pdev Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 03/20] drm/ast: " Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 04/20] drm/bochs: " Thomas Zimmermann
2020-12-02 8:10 ` Gerd Hoffmann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 05/20] drm/cirrus: " Thomas Zimmermann
2020-12-02 8:10 ` Gerd Hoffmann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 06/20] drm/gma500: Fix trailing whitespaces Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 07/20] drm/gma500: Remove references to struct drm_device.pdev Thomas Zimmermann
2020-12-01 10:35 ` Thomas Zimmermann [this message]
2020-12-02 0:42 ` [Intel-gfx] [PATCH v2 08/20] drm/hibmc: " tiantao (H)
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 09/20] drm/i915: " Thomas Zimmermann
2020-12-08 7:59 ` Thomas Zimmermann
2020-12-10 9:03 ` Jani Nikula
2020-12-10 9:24 ` Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 10/20] drm/i915/gt: " Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 11/20] drm/i915/gvt: " Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 12/20] drm/mgag200: " Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 13/20] drm/nouveau: " Thomas Zimmermann
2020-12-08 8:00 ` Thomas Zimmermann
2020-12-09 18:04 ` Jeremy Cline
2020-12-10 7:56 ` Thomas Zimmermann
2020-12-10 14:25 ` Jeremy Cline
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 14/20] drm/qxl: " Thomas Zimmermann
2020-12-02 8:11 ` Gerd Hoffmann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 15/20] drm/radeon: Fix trailing whitespaces Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 16/20] drm/radeon: Remove references to struct drm_device.pdev Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 17/20] drm/vboxvideo: " Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 18/20] drm/virtgpu: " Thomas Zimmermann
2020-12-02 8:12 ` Gerd Hoffmann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 19/20] drm/vmwgfx: " Thomas Zimmermann
2020-12-01 10:35 ` [Intel-gfx] [PATCH v2 20/20] drm: Upcast struct drm_device.dev to struct pci_device; replace pdev Thomas Zimmermann
2020-12-01 11:17 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Move struct drm_device.pdev to legacy (rev2) Patchwork
2020-12-01 11:47 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-12-01 17:52 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201103542.2182-9-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=john.stultz@linaro.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=nouveau@lists.freedesktop.org \
--cc=puck.chen@hisilicon.com \
--cc=sam@ravnborg.org \
--cc=spice-devel@lists.freedesktop.org \
--cc=tiantao6@hisilicon.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox