From: Anshuman Gupta <anshuman.gupta@intel.com>
To: Imre Deak <imre.deak@intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout
Date: Wed, 9 Dec 2020 21:23:02 +0530 [thread overview]
Message-ID: <20201209155302.GM30377@intel.com> (raw)
In-Reply-To: <20201209153952.3397959-1-imre.deak@intel.com>
On 2020-12-09 at 21:09:52 +0530, Imre Deak wrote:
> For an enabled DSC during HW readout the corresponding power reference
> is taken along the CRTC power domain references in
> get_crtc_power_domains(). Remove the incorrect get ref from the DSI
> encoder hook.
Looks good to me.
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com>
>
> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/display/icl_dsi.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index a9439b415603..b3533a32f8ba 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -1616,10 +1616,6 @@ static void gen11_dsi_get_power_domains(struct intel_encoder *encoder,
>
> get_dsi_io_power_domains(i915,
> enc_to_intel_dsi(encoder));
> -
> - if (crtc_state->dsc.compression_enable)
> - intel_display_power_get(i915,
> - intel_dsc_power_domain(crtc_state));
> }
>
> static bool gen11_dsi_get_hw_state(struct intel_encoder *encoder,
> --
> 2.25.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-12-09 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 15:39 [Intel-gfx] [PATCH] drm/i915/icl: Fix initing the DSI DSC power refcount during HW readout Imre Deak
2020-12-09 15:53 ` Anshuman Gupta [this message]
2020-12-09 16:44 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2020-12-09 18:30 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2020-12-10 18:45 ` Imre Deak
2021-01-07 7:01 ` [Intel-gfx] [PATCH] " Jani Nikula
2021-01-07 12:56 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209155302.GM30377@intel.com \
--to=anshuman.gupta@intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox