Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Huang Rui <ray.huang@amd.com>,
	DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 28/65] drm/ttm: WARN_ON non-empty lru when disabling a resource manager
Date: Fri, 11 Dec 2020 17:30:56 +0100	[thread overview]
Message-ID: <20201211163056.GV401619@phenom.ffwll.local> (raw)
In-Reply-To: <CAKMK7uGG0B+NfBFO7j7E9FnxY4ET+bCgTHp5vKKXEYDX_1aR+Q@mail.gmail.com>

On Fri, Oct 23, 2020 at 04:56:20PM +0200, Daniel Vetter wrote:
> On Fri, Oct 23, 2020 at 4:54 PM Christian König
> <christian.koenig@amd.com> wrote:
> >
> > Am 23.10.20 um 14:21 schrieb Daniel Vetter:
> > > ttm_resource_manager->use_type is only used for runtime changes by
> > > vmwgfx. I think ideally we'd push this functionality into drivers -
> > > ttm itself does not provide any locking to guarantee this is safe, so
> > > the only way this can work at runtime is if the driver does provide
> > > additional guarantees. vwmgfx does that through the
> > > vmw_private->reservation_sem. Therefore supporting this feature in
> > > shared code feels a bit misplaced.
> > >
> > > As a first step add a WARN_ON to make sure the resource manager is
> > > empty. This is just to make sure I actually understand correctly what
> > > vmwgfx is doing, and to make sure an eventual subsequent refactor
> > > doesn't break anything.
> > >
> > > This check should also be useful for other drivers, to make sure they
> > > haven't leaked anything.
> > >
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > Cc: Christian Koenig <christian.koenig@amd.com>
> > > Cc: Huang Rui <ray.huang@amd.com>
> >
> > I'm pretty sure that this will trigger for vmwgfx. But that's what it is
> > supposed to do, isn't it?
> 
> Yeah, this is an accidental dump of my wip pile, and it's not done yet
> at all. Please disregard (at least for now).
> -Daniel
> 
> > Reviewed-by: Christian König <christian.koenig@amd.com>

Ok decided to submit these 3 patches finally, including the 2 vmwgfx fixes
which should avoid the splat. I included your r-b, pls complain if that's
not ok anymore.

Thanks, Daniel

> >
> > > ---
> > >   include/drm/ttm/ttm_resource.h | 4 ++++
> > >   1 file changed, 4 insertions(+)
> > >
> > > diff --git a/include/drm/ttm/ttm_resource.h b/include/drm/ttm/ttm_resource.h
> > > index f48a70d39ac5..789ec477b607 100644
> > > --- a/include/drm/ttm/ttm_resource.h
> > > +++ b/include/drm/ttm/ttm_resource.h
> > > @@ -191,6 +191,10 @@ struct ttm_resource {
> > >   static inline void
> > >   ttm_resource_manager_set_used(struct ttm_resource_manager *man, bool used)
> > >   {
> > > +     int i;
> > > +
> > > +     for (i = 0; i < TTM_MAX_BO_PRIORITY; i++)
> > > +             WARN_ON(!list_empty(&man->lru[i]));
> > >       man->use_type = used;
> > >   }
> > >
> >
> 
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2020-12-11 16:31 UTC|newest]

Thread overview: 76+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-21 16:32 [Intel-gfx] [PATCH 1/3] drm/atomic-helpers: remove legacy_cursor_update hacks Daniel Vetter
2020-10-21 16:32 ` [Intel-gfx] [PATCH 2/3] drm/vc4: Drop legacy_cursor_update override Daniel Vetter
2020-10-22 13:19   ` Maxime Ripard
2020-10-21 16:32 ` [Intel-gfx] [PATCH 3/3] drm/doc: Document legacy_cursor_update better Daniel Vetter
2020-10-21 17:14 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/atomic-helpers: remove legacy_cursor_update hacks Patchwork
2020-10-21 17:44 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-10-22 13:36 ` [Intel-gfx] [PATCH 1/3] " Kazlauskas, Nicholas
2020-10-22 14:03   ` Daniel Vetter
2020-10-22 17:02 ` Rob Clark
2020-10-22 17:21   ` Rob Clark
2020-10-22 19:16     ` Daniel Vetter
2020-10-23 15:02       ` Rob Clark
2020-10-23 16:00         ` Daniel Vetter
2020-10-23 16:21           ` Rob Clark
2020-10-22 20:17 ` [Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [1/3] drm/atomic-helpers: remove legacy_cursor_update hacks (rev2) Patchwork
2020-10-23 12:21 ` [Intel-gfx] [PATCH 01/65] drm/vc4: Drop legacy_cursor_update override Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 02/65] drm/doc: Document legacy_cursor_update better Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 03/65] mm: Track mmu notifiers in fs_reclaim_acquire/release Daniel Vetter
2020-10-27 18:51     ` Christoph Hellwig
2020-10-27 19:01       ` Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 04/65] mm: Extract might_alloc() debug check Daniel Vetter
2020-10-23 14:14     ` Vlastimil Babka
2020-10-23 14:16     ` Matthew Wilcox
2020-10-23 14:37       ` Daniel Vetter
2020-10-23 14:45         ` Daniel Vetter
2020-10-23 20:53     ` Paul E. McKenney
2020-10-23 12:21   ` [Intel-gfx] [PATCH 05/65] drm/atomic-helper: Add dma-fence annotations Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 06/65] drm/vkms: Annotate vblank timer Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 07/65] drm/vblank: Annotate with dma-fence signalling section Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 08/65] drm/amdgpu: add dma-fence annotations to atomic commit path Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 09/65] drm/komeda: Annotate dma-fence critical section in " Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 10/65] drm/malidp: " Daniel Vetter
2020-10-28 13:27     ` Liviu Dudau
2020-10-23 12:21   ` [Intel-gfx] [PATCH 11/65] drm/atmel: Use drm_atomic_helper_commit Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 12/65] drm/imx: Annotate dma-fence critical section in commit path Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 13/65] drm/omapdrm: " Daniel Vetter
2020-10-26  7:13     ` Tomi Valkeinen
2020-10-23 12:21   ` [Intel-gfx] [PATCH 14/65] drm/rcar-du: " Daniel Vetter
2020-12-16  1:29     ` Laurent Pinchart
2020-12-16  9:41       ` Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 15/65] drm/tegra: " Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 16/65] drm/tidss: " Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 17/65] drm/scheduler: use dma-fence annotations in main thread Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 18/65] drm/amdgpu: use dma-fence annotations in cs_submit() Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 19/65] drm/amdgpu: s/GFP_KERNEL/GFP_ATOMIC in scheduler code Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 20/65] drm/scheduler: use dma-fence annotations in tdr work Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 21/65] drm/amdgpu: use dma-fence annotations for gpu reset code Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 22/65] Revert "drm/amdgpu: add fbdev suspend/resume on gpu reset" Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 23/65] drm/i915: Annotate dma_fence_work Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 24/65] Revert "drm/i915: Annotate dma_fence_work" Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 25/65] drm/nouveau: Drop mutex_lock_nested for atomic Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 26/65] drm/vmwgfx: Drop svga_lock Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 27/65] drm/vmwgfx: Always evict vram _before_ disabling it Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 28/65] drm/ttm: WARN_ON non-empty lru when disabling a resource manager Daniel Vetter
2020-10-23 14:54     ` Christian König
2020-10-23 14:56       ` Daniel Vetter
2020-12-11 16:30         ` Daniel Vetter [this message]
2020-10-23 12:21   ` [Intel-gfx] [PATCH 29/65] s390/pci: Remove races against pte updates Daniel Vetter
2020-10-23 12:26     ` Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 30/65] drm/exynos: Stop using frame_vector helpers Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 31/65] drm/exynos: Use FOLL_LONGTERM for g2d cmdlists Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 32/65] misc/habana: Stop using frame_vector helpers Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 33/65] misc/habana: Use FOLL_LONGTERM for userptr Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 34/65] mm/frame-vector: Use FOLL_LONGTERM Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 35/65] media: videobuf2: Move frame_vector into media subsystem Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 36/65] mm: Close race in generic_access_phys Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 37/65] mm: Add unsafe_follow_pfn Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 38/65] media/videbuf1|2: Mark follow_pfn usage as unsafe Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 39/65] vfio/type1: Mark follow_pfn " Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 40/65] PCI: Obey iomem restrictions for procfs mmap Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 41/65] /dev/mem: Only set filp->f_mapping Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 42/65] resource: Move devmem revoke code to resource framework Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 43/65] sysfs: Support zapping of binary attr mmaps Daniel Vetter
2020-10-23 12:21   ` [Intel-gfx] [PATCH 44/65] PCI: Revoke mappings like devmem Daniel Vetter
2020-10-23 12:25   ` [Intel-gfx] [PATCH 01/65] drm/vc4: Drop legacy_cursor_update override Daniel Vetter
2020-10-23 12:26 ` [Intel-gfx] [PATCH] drm/atomic-helpers: remove legacy_cursor_update hacks Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201211163056.GV401619@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=christian.koenig@amd.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ray.huang@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox