From: Gary C Wang <gary.c.wang@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915: enhance legacy HPD disconnection flow for 4K pipe compute in GLK
Date: Fri, 19 Feb 2021 15:06:31 +0800 [thread overview]
Message-ID: <20210219070631.19853-1-gary.c.wang@intel.com> (raw)
HDMI PHY is not available to use when its HDMI disaply plug-in, and power-off
then power-on as soon as getting a hotplug. In above cases where there's a HDMI
connector physically connected but it can't be used by GLK with 4K pipe then blank
screen (lacking of edid-update & mode-probing) then need return false, since the
rest of the driver should pretty much treat the port as disconnected.
As previous result, handshaking through is required around connect and disconnect.
Otherwise it would be in a inconsistent state as port is disconnected but with a
valid HDMI type.
Also setting it to return HDMI disconnect for any future calls to
intel_digital_port_connected(), this way we don't need to check if port is marked
as safe everytime.
References: https://gitlab.freedesktop.org/drm/intel/-/issues/3092
Test-steps: setup HDMI 4K@60Hz in GLK then to power monitor off then on to get display
recovery correctly
Tested-by: Gary C Wang <gary.c.wang@intel.com>
Reviewed-by: Gordon Sylin <gordon.sylin@intel.com>
Signed-off-by: Gary C Wang <gary.c.wang@intel.com>
---
drivers/gpu/drm/i915/display/intel_hdmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/intel_hdmi.c
index 7f384f259fc8..039cdbfe71a0 100644
--- a/drivers/gpu/drm/i915/display/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/display/intel_hdmi.c
@@ -2705,7 +2705,7 @@ intel_hdmi_detect(struct drm_connector *connector, bool force)
wakeref = intel_display_power_get(dev_priv, POWER_DOMAIN_GMBUS);
- if (INTEL_GEN(dev_priv) >= 11 &&
+ if ((INTEL_GEN(dev_priv) >= 11 || IS_GEMINILAKE(dev_priv)) &&
!intel_digital_port_connected(encoder))
goto out;
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2021-02-19 7:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 7:06 Gary C Wang [this message]
2021-02-19 7:21 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: enhance legacy HPD disconnection flow for 4K pipe compute in GLK Patchwork
2021-02-19 7:50 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-02-19 9:15 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
[not found] <20210219062539.19282-1-gary.c.wang@intel.com>
2021-02-19 15:36 ` [Intel-gfx] [PATCH] " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219070631.19853-1-gary.c.wang@intel.com \
--to=gary.c.wang@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox