Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add HWMON power sensor support

From: kernel test robot <lkp@intel.com>
To: Dale B Stimson <dale.b.stimson@intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dg1: Add HWMON power sensor support
Date: Fri, 26 Mar 2021 06:23:38 +0800	[thread overview]
Message-ID: <202103260618.PnvyjBzD-lkp@intel.com> (raw)
In-Reply-To: <20210325195230.97238-1-dale.b.stimson@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1888 bytes --]

Hi Dale,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip next-20210325]
[cannot apply to v5.12-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Dale-B-Stimson/drm-i915-dg1-Add-HWMON-power-sensor-support/20210326-035458
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/a4d0cd77d477a9f1389f4af775878deea0749632
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Dale-B-Stimson/drm-i915-dg1-Add-HWMON-power-sensor-support/20210326-035458
        git checkout a4d0cd77d477a9f1389f4af775878deea0749632
        # save the attached .config to linux build tree
        make W=1 ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/i915_hwmon.c:19: warning: wrong kernel-doc identifier on line:
    * SF_* - scale factors for particular quantities.

vim +19 drivers/gpu/drm/i915/i915_hwmon.c

    17	
    18	/**
  > 19	 * SF_* - scale factors for particular quantities.
    20	 * The hwmon standard says that quantities of the given types are specified
    21	 * in the given units:
    22	 * - time   - milliseconds
    23	 * - power  - microwatts
    24	 * - energy - microjoules
    25	 */
    26	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65454 bytes --]

[-- Attachment #3: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx