From: Harish Chegondi <harish.chegondi@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915/display/psr: Fix cppcheck warnings
Date: Wed, 14 Apr 2021 17:45:36 -0700 [thread overview]
Message-ID: <20210415004536.GA75059@intel.com> (raw)
In-Reply-To: <20210409231738.238682-1-jose.souza@intel.com>
On Fri, Apr 09, 2021 at 04:17:38PM -0700, José Roberto de Souza wrote:
> Fix redundant condition, caught in cppcheck by kernel test robot.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun@intel.com>
> Fixes: b64d6c51380b ("drm/i915/display: Support PSR Multiple Instances")
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Harish Chegondi <harish.chegondi@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_psr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 2627d0b558f3..06cb286e9a4a 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -1532,8 +1532,7 @@ void intel_psr_wait_for_idle(const struct intel_crtc_state *new_crtc_state)
> u32 psr_status;
>
> mutex_lock(&intel_dp->psr.lock);
> - if (!intel_dp->psr.enabled ||
> - (intel_dp->psr.enabled && intel_dp->psr.psr2_enabled)) {
> + if (!intel_dp->psr.enabled || intel_dp->psr.psr2_enabled) {
> mutex_unlock(&intel_dp->psr.lock);
> continue;
> }
> --
> 2.31.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2021-04-15 0:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 23:17 [Intel-gfx] [PATCH] drm/i915/display/psr: Fix cppcheck warnings José Roberto de Souza
2021-04-09 23:26 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-04-09 23:48 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-04-10 1:38 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-04-15 0:45 ` Harish Chegondi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210415004536.GA75059@intel.com \
--to=harish.chegondi@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jose.souza@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox