Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: "José Roberto de Souza" <jose.souza@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix a possible use of uninitialized variable in remap_io_sg()
Date: Fri, 14 May 2021 07:49:23 +0200	[thread overview]
Message-ID: <20210514054923.GA5323@lst.de> (raw)
In-Reply-To: <20210513232841.147989-1-jose.souza@intel.com>

On Thu, May 13, 2021 at 04:28:41PM -0700, José Roberto de Souza wrote:
> If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first
> iteration, err is uninitialized causing a wrong call to zap_vma_ptes().

But scatterlist must have at least one valid segment.  So while the
patch looks ok, please clearly mark that this is a false positive from
the static checker in the commit log.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2021-05-14  5:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-13 23:28 [Intel-gfx] [PATCH] drm/i915: Fix a possible use of uninitialized variable in remap_io_sg() José Roberto de Souza
2021-05-14  0:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-05-14  2:19 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-05-14  5:49 ` Christoph Hellwig [this message]
2021-05-15  0:23   ` [Intel-gfx] [PATCH] " Souza, Jose
2021-05-17 12:24     ` hch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514054923.GA5323@lst.de \
    --to=hch@lst.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox