From: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: thomas.hellstrom@linux.intel.com,
intel-gfx@lists.freedesktop.org,
"Zbigniew Kempczyński" <zbigniew.kempczynski@linux.intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 4/9] tests/gem_gpgpu_fill: Convert from simple to standard igt_main
Date: Mon, 24 May 2021 08:32:17 +0200 [thread overview]
Message-ID: <20210524063217.GC3715@zkempczy-mobl2> (raw)
In-Reply-To: <20210519145337.255167-5-matthew.auld@intel.com>
On Wed, May 19, 2021 at 03:53:32PM +0100, Matthew Auld wrote:
> From: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
>
> As we need to add new test variants, convert the code to standard
> igt_main format so those variants can be easily accommodated.
>
> Signed-off-by: Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@linux.intel.com>
> Signed-off-by: Matthew Auld <matthew.auld@intel.com>
I'm not sure but Janusz likely started migration so you can remove
me from SoB. Then I can give:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
> ---
> tests/i915/gem_gpgpu_fill.c | 25 ++++++++++++++++---------
> 1 file changed, 16 insertions(+), 9 deletions(-)
>
> diff --git a/tests/i915/gem_gpgpu_fill.c b/tests/i915/gem_gpgpu_fill.c
> index c605629f..5b11fb35 100644
> --- a/tests/i915/gem_gpgpu_fill.c
> +++ b/tests/i915/gem_gpgpu_fill.c
> @@ -123,20 +123,27 @@ static void gpgpu_fill(data_t *data, igt_fillfunc_t fill)
>
> munmap(ptr, buf->surface[0].size);
> }
> -
> -igt_simple_main
> +igt_main
> {
> data_t data = {0, };
> igt_fillfunc_t fill_fn = NULL;
>
> - data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
> - data.devid = intel_get_drm_devid(data.drm_fd);
> - igt_require_gem(data.drm_fd);
> - data.bops = buf_ops_create(data.drm_fd);
> + igt_fixture {
> + data.drm_fd = drm_open_driver_render(DRIVER_INTEL);
> + data.devid = intel_get_drm_devid(data.drm_fd);
> + igt_require_gem(data.drm_fd);
> + data.bops = buf_ops_create(data.drm_fd);
> +
> + fill_fn = igt_get_gpgpu_fillfunc(data.devid);
> +
> + igt_require_f(fill_fn, "no gpgpu-fill function\n");
>
> - fill_fn = igt_get_gpgpu_fillfunc(data.devid);
> + }
>
> - igt_require_f(fill_fn, "no gpgpu-fill function\n");
> + igt_subtest("basic")
> + gpgpu_fill(&data, fill_fn);
>
> - gpgpu_fill(&data, fill_fn);
> + igt_fixture {
> + buf_ops_destroy(data.bops);
> + }
> }
> --
> 2.26.3
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-05-24 6:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-19 14:53 [Intel-gfx] [PATCH i-g-t 0/9] DG1/LMEM uAPI basics v2 Matthew Auld
2021-05-19 14:53 ` [Intel-gfx] [PATCH i-g-t 1/9] i915_drm.h sync Matthew Auld
2021-05-19 14:53 ` [Intel-gfx] [PATCH i-g-t 2/9] lib/i915/gem_create: Add gem_create_ext Matthew Auld
2021-05-19 14:53 ` [Intel-gfx] [PATCH i-g-t 3/9] lib/i915/intel_memory_region: Add new memory region lib Matthew Auld
2021-05-19 14:53 ` [Intel-gfx] [PATCH i-g-t 4/9] tests/gem_gpgpu_fill: Convert from simple to standard igt_main Matthew Auld
2021-05-24 6:32 ` Zbigniew Kempczyński [this message]
2021-05-19 14:53 ` [Intel-gfx] [PATCH i-g-t 5/9] tests/i915/gem_exec_basic: Use memory region interface Matthew Auld
2021-05-19 14:53 ` [Intel-gfx] [PATCH i-g-t 6/9] tests/i915/gem_gpgpu_fill: " Matthew Auld
2021-05-24 6:29 ` Zbigniew Kempczyński
2021-05-19 14:53 ` [Intel-gfx] [PATCH i-g-t 7/9] tests/i915/gem_media_fill: " Matthew Auld
2021-05-24 6:30 ` Zbigniew Kempczyński
2021-05-19 14:53 ` [Intel-gfx] [PATCH i-g-t 8/9] tests/i915/gem_create: exercise placements extension Matthew Auld
2021-05-19 14:53 ` [Intel-gfx] [PATCH i-g-t 9/9] tests/i915/gem_exec_basic: Iterate over all memory regions Matthew Auld
2021-05-21 8:34 ` [Intel-gfx] [PATCH i-g-t 0/9] DG1/LMEM uAPI basics v2 Petri Latvala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524063217.GC3715@zkempczy-mobl2 \
--to=zbigniew.kempczynski@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
--cc=zbigniew.kempczynski@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox