From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
matthew.auld@intel.com
Subject: [Intel-gfx] [PATCH 0/2] drm/i915/gem: dma-buf fixes for migration
Date: Wed, 30 Jun 2021 15:06:59 +0200 [thread overview]
Message-ID: <20210630130701.349458-1-thomas.hellstrom@linux.intel.com> (raw)
Our dma-buf code is currently completely broken unless the importer is
dynamic in which case the sg_list caching saves the day. In particular,
the case where another instance of our driver tries to import a dma-buf
exported by our driver ends up in a recursive lock.
Since the recent TTM migration work spec specifies to fix up the dma-buf
code with migration and there's no point in doing so when it's
completely broken, take a first step to make at least the exporter obey
the dma-buf locking rules the dma-buf core enforces for a dynamic exporter:
- Implement and act on pin- and unpin.
- Call move_notify if migrating. (we opt not to migrate while dma-buf_mapped).
- map_dma_buf() is unconditionally called locked.
Add a selftest that ensures that it works with both our own and a fake
dynamic importer.
Also implement migration in the second patch before pinning in pin()
and map_dma_buf().
Note that the importer remains broken for other non-dynamic exporters, but
at least not for the same-driver-separate-instances case.
Regardless whether we want to fix this now with this series, or in an
unspecified future, the selftest may come in handy.
Thomas Hellström (2):
drm/i915/gem: Make our dma-buf exporter dynamic
drm/i915/gem: Migrate to system at dma-buf map time
drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c | 48 ++++++-
.../drm/i915/gem/selftests/i915_gem_dmabuf.c | 118 +++++++++++++++++-
2 files changed, 162 insertions(+), 4 deletions(-)
--
2.31.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next reply other threads:[~2021-06-30 13:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 13:06 Thomas Hellström [this message]
2021-06-30 13:07 ` [Intel-gfx] [PATCH 1/2] drm/i915/gem: Make our dma-buf exporter dynamic Thomas Hellström
2021-06-30 14:01 ` Daniel Vetter
2021-06-30 14:06 ` Ruhl, Michael J
2021-06-30 17:14 ` Daniel Vetter
2021-06-30 13:07 ` [Intel-gfx] [PATCH 2/2] drm/i915/gem: Migrate to system at dma-buf map time Thomas Hellström
2021-06-30 17:46 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gem: dma-buf fixes for migration Patchwork
2021-06-30 18:15 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210630130701.349458-1-thomas.hellstrom@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox