From: Matthew Brost <matthew.brost@intel.com>
To: <igt-dev@lists.freedesktop.org>
Cc: <intel-gfx@lists.freedesktop.org>
Subject: [Intel-gfx] [PATCH i-g-t 2/3] i915/gem_ctx_shared: Make gem_ctx_shared understand static priority mapping
Date: Tue, 3 Aug 2021 18:23:02 -0700 [thread overview]
Message-ID: <20210804012303.158392-3-matthew.brost@intel.com> (raw)
In-Reply-To: <20210804012303.158392-1-matthew.brost@intel.com>
The i915 currently has 2k visible priority levels which are currently
unique. This is changing to statically map these 2k levels into 3
buckets:
low: < 0
mid: 0
high: > 0
Update gem_ctx_shared to understand this. This entails updating
promotion test to use 3 levels that will map into different buckets and
also add bit of delay after releasing a cork beforing completing the
spinners.
v2: Add a delay between starting releasing spinner and cork in
promotion
Signed-off-by: Matthew Brost <matthew.brost@intel.com>
---
tests/i915/gem_ctx_shared.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/tests/i915/gem_ctx_shared.c b/tests/i915/gem_ctx_shared.c
index 4441e6eb7..b3a156ca4 100644
--- a/tests/i915/gem_ctx_shared.c
+++ b/tests/i915/gem_ctx_shared.c
@@ -571,7 +571,8 @@ create_highest_priority(int i915, const intel_ctx_cfg_t *cfg)
}
static void unplug_show_queue(int i915, struct igt_cork *c,
- const intel_ctx_cfg_t *cfg, unsigned int engine)
+ const intel_ctx_cfg_t *cfg, unsigned int engine,
+ unsigned int usec_delay)
{
igt_spin_t *spin[MAX_ELSP_QLEN];
@@ -583,6 +584,7 @@ static void unplug_show_queue(int i915, struct igt_cork *c,
igt_cork_unplug(c); /* batches will now be queued on the engine */
igt_debugfs_dump(i915, "i915_engine_info");
+ usleep(usec_delay);
for (int n = 0; n < ARRAY_SIZE(spin); n++)
igt_spin_free(i915, spin[n]);
@@ -734,7 +736,7 @@ static void reorder(int i915, const intel_ctx_cfg_t *cfg,
store_dword(i915, ctx[LO], ring, scratch, 0, ctx[LO]->id, plug, 0);
store_dword(i915, ctx[HI], ring, scratch, 0, ctx[HI]->id, plug, 0);
- unplug_show_queue(i915, &cork, &q_cfg, ring);
+ unplug_show_queue(i915, &cork, &q_cfg, ring, 0);
gem_close(i915, plug);
ptr = gem_mmap__device_coherent(i915, scratch, 0, 4096, PROT_READ);
@@ -771,10 +773,10 @@ static void promotion(int i915, const intel_ctx_cfg_t *cfg, unsigned ring)
gem_context_set_priority(i915, ctx[LO]->id, MIN_PRIO);
ctx[HI] = intel_ctx_create(i915, &q_cfg);
- gem_context_set_priority(i915, ctx[HI]->id, 0);
+ gem_context_set_priority(i915, ctx[HI]->id, MAX_PRIO);
ctx[NOISE] = intel_ctx_create(i915, &q_cfg);
- gem_context_set_priority(i915, ctx[NOISE]->id, MIN_PRIO/2);
+ gem_context_set_priority(i915, ctx[NOISE]->id, 0);
result = gem_create(i915, 4096);
dep = gem_create(i915, 4096);
@@ -795,7 +797,7 @@ static void promotion(int i915, const intel_ctx_cfg_t *cfg, unsigned ring)
store_dword(i915, ctx[HI], ring, result, 0, ctx[HI]->id, 0, 0);
- unplug_show_queue(i915, &cork, &q_cfg, ring);
+ unplug_show_queue(i915, &cork, &q_cfg, ring, 250000);
gem_close(i915, plug);
ptr = gem_mmap__device_coherent(i915, dep, 0, 4096, PROT_READ);
--
2.28.0
next prev parent reply other threads:[~2021-08-04 1:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 1:23 [Intel-gfx] [PATCH i-g-t 0/3] IGT fixes for priority management + capture with GuC submission Matthew Brost
2021-08-04 1:23 ` [Intel-gfx] [PATCH i-g-t 1/3] i915/gem_exec_schedule: Make gem_exec_schedule understand static priority mapping Matthew Brost
2021-08-13 23:24 ` Daniele Ceraolo Spurio
2021-08-16 16:39 ` Matthew Brost
2021-08-04 1:23 ` Matthew Brost [this message]
2021-08-04 1:23 ` [Intel-gfx] [PATCH i-g-t 3/3] i915/gem_exec_capture: Update to support GuC based resets Matthew Brost
2021-08-14 0:28 ` Daniele Ceraolo Spurio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804012303.158392-3-matthew.brost@intel.com \
--to=matthew.brost@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox