Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup guardband

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4417 bytes --]

Hi Vandita,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip next-20210820]
[cannot apply to v5.14-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vandita-Kulkarni/Enable-mipi-dsi-on-XELPD/20210823-112313
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-a015-20210822 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 79b55e5038324e61a3abf4e6a9a949c473edd858)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d75ce0657c5bed32b206ab0461ea42eea7514436
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vandita-Kulkarni/Enable-mipi-dsi-on-XELPD/20210823-112313
        git checkout d75ce0657c5bed32b206ab0461ea42eea7514436
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/display/icl_dsi.c:1290:27: error: use of undeclared identifier '_TGL_DSI_CHKN_REG_0'
                           intel_de_rmw(dev_priv, TGL_DSI_CHKN_REG(port),
                                                  ^
   drivers/gpu/drm/i915/i915_reg.h:11619:11: note: expanded from macro 'TGL_DSI_CHKN_REG'
                                                       _TGL_DSI_CHKN_REG_0, \
                                                       ^
   drivers/gpu/drm/i915/display/icl_dsi.c:1290:27: error: use of undeclared identifier '_TGL_DSI_CHKN_REG_1'
   drivers/gpu/drm/i915/i915_reg.h:11620:11: note: expanded from macro 'TGL_DSI_CHKN_REG'
                                                       _TGL_DSI_CHKN_REG_1)
                                                       ^
   drivers/gpu/drm/i915/display/icl_dsi.c:1290:27: error: use of undeclared identifier '_TGL_DSI_CHKN_REG_0'
   drivers/gpu/drm/i915/i915_reg.h:11619:11: note: expanded from macro 'TGL_DSI_CHKN_REG'
                                                       _TGL_DSI_CHKN_REG_0, \
                                                       ^
>> drivers/gpu/drm/i915/display/icl_dsi.c:1289:3: warning: add explicit braces to avoid dangling else [-Wdangling-else]
                   for_each_dsi_port(port, intel_dsi->ports)
                   ^
   drivers/gpu/drm/i915/display/intel_dsi.h:145:2: note: expanded from macro 'for_each_dsi_port'
           for_each_port_masked(__port, __ports_mask)
           ^
   drivers/gpu/drm/i915/display/intel_display.h:374:3: note: expanded from macro 'for_each_port_masked'
                   for_each_if((__ports_mask) & BIT(__port))
                   ^
   include/drm/drm_util.h:63:53: note: expanded from macro 'for_each_if'
   #define for_each_if(condition) if (!(condition)) {} else
                                                       ^
   1 warning and 3 errors generated.


vim +1289 drivers/gpu/drm/i915/display/icl_dsi.c

  1273	
  1274	/*
  1275	 * Wa_16012360555:ADLP
  1276	 * SW will have to program the "LP to HS Wakeup Guardband"
  1277	 * field (bits 15:12) of register offset 0x6B0C0 (DSI0)
  1278	 * and 0x6B8C0 (DSI1) to a value of 4 to account for the repeaters
  1279	 * on the HS Request/Ready PPI signaling between
  1280	 * the Display engine and the DPHY.
  1281	 */
  1282	static void adlp_set_lp_hs_wakeup_gb(struct intel_encoder *encoder)
  1283	{
  1284		struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
  1285		struct intel_dsi *intel_dsi = enc_to_intel_dsi(encoder);
  1286		enum port port;
  1287	
  1288		if (DISPLAY_VER(dev_priv) == 13)
> 1289			for_each_dsi_port(port, intel_dsi->ports)
  1290				intel_de_rmw(dev_priv, TGL_DSI_CHKN_REG(port),
  1291					     TGL_DSI_CHKN_LSHS_GB, 0x4);
  1292	}
  1293	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37549 bytes --]