Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Imre Deak <imre.deak@intel.com>
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH 3/5] drm/i915/adlp: Assert that VMAs in DPT start at 0
Date: Fri, 27 Aug 2021 18:09:53 +0300	[thread overview]
Message-ID: <20210827150955.3343520-4-imre.deak@intel.com> (raw)
In-Reply-To: <20210827150955.3343520-1-imre.deak@intel.com>

Atm the DPT object can accomodate only one VMA, so the VMA offset will
be always 0. Add an assert for this.

Signed-off-by: Imre Deak <imre.deak@intel.com>
---
 drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
index 724e7b04f3b63..f50282b60de44 100644
--- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
+++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
@@ -993,6 +993,11 @@ static u32 skl_surf_address(const struct intel_plane_state *plane_state,
 	u32 offset = plane_state->view.color_plane[color_plane].offset;
 
 	if (intel_fb_uses_dpt(fb)) {
+		/*
+		 * The DPT object contains only one vma, so the VMA's offset
+		 * within the DPT is always 0.
+		 */
+		WARN_ON(plane_state->dpt_vma->node.start);
 		WARN_ON(offset & 0x1fffff);
 		return offset >> 9;
 	} else {
-- 
2.27.0


  parent reply	other threads:[~2021-08-27 15:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 15:09 [Intel-gfx] [PATCH 0/5] drm/i915/adlp: Add support for remapping CCS FBs Imre Deak
2021-08-27 15:09 ` [Intel-gfx] [PATCH 1/5] drm/i915: Use tile block based dimensions for CCS origin x, y check Imre Deak
2021-08-27 15:09 ` [Intel-gfx] [PATCH 2/5] drm/i915/adlp: Require always a power-of-two sized CCS surface stride Imre Deak
2021-08-27 22:31   ` kernel test robot
2021-08-28  0:50   ` kernel test robot
2021-08-30  2:29   ` kernel test robot
2021-08-30  2:29   ` [Intel-gfx] [RFC PATCH] drm/i915/adlp: gen12_ccs_aux_stride() can be static kernel test robot
2021-08-27 15:09 ` Imre Deak [this message]
2021-08-27 15:09 ` [Intel-gfx] [PATCH 4/5] drm/i915: Follow a new->old platform check order in intel_fb_stride_alignment Imre Deak
2021-08-27 15:09 ` [Intel-gfx] [PATCH 5/5] drm/i915/adlp: Add support for remapping CCS FBs Imre Deak
2021-09-04 11:54   ` Juha-Pekka Heikkila
2021-09-05 10:55     ` Imre Deak
2021-08-27 16:08 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-08-27 16:10 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-08-27 16:53 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2021-08-27 17:45   ` Imre Deak
2021-08-27 23:41     ` Vudum, Lakshminarayana
2021-08-27 23:38 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-08-28  1:05 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210827150955.3343520-4-imre.deak@intel.com \
    --to=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox