From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
David Weinehall <david.weinehall@linux.intel.com>,
Tilak Tangudu <tilak.tangudu@intel.com>,
Imre Deak <imre.deak@intel.com>,
Anshuman Gupta <anshuman.gupta@intel.com>
Subject: [Intel-gfx] [PATCH 3/3] drm/i915: Enable runtime pm autosuspend by default
Date: Fri, 10 Sep 2021 13:44:47 -0400 [thread overview]
Message-ID: <20210910174447.289750-3-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <20210910174447.289750-1-rodrigo.vivi@intel.com>
Let's enable runtime pm autosuspend by default everywhere.
But at this time let's not touch the autosuspend_delay time,
what caused some regression on our previous attempt.
v2: CI on some gen9 platforms was not clean. But it came
pretty clean on newer generations. For now, let's
pick gen12 and newer. We will return later to extend
that to older platforms.
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: David Weinehall <david.weinehall@linux.intel.com>
Cc: Tilak Tangudu <tilak.tangudu@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Anshuman Gupta <anshuman.gupta@intel.com> #v1
---
drivers/gpu/drm/i915/intel_runtime_pm.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index f28b5bab61b4..f91a04c3ef14 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -605,6 +605,10 @@ void intel_runtime_pm_enable(struct intel_runtime_pm *rpm)
pm_runtime_use_autosuspend(kdev);
}
+ /* XXX: Enable by default only for newer platforms for now */
+ if (GRAPHICS_VER(i915) >= 12)
+ pm_runtime_allow(kdev);
+
/*
* The core calls the driver load handler with an RPM reference held.
* We drop that here and will reacquire it during unloading in
--
2.31.1
next prev parent reply other threads:[~2021-09-10 17:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 17:44 [Intel-gfx] [PATCH 1/3] drm/i915/runtime_pm: Consolidate runtime_pm functions Rodrigo Vivi
2021-09-10 17:44 ` [Intel-gfx] [PATCH 2/3] drm/i915: Disallow D3Cold Rodrigo Vivi
2021-09-13 10:52 ` Gupta, Anshuman
2021-09-13 18:48 ` Vivi, Rodrigo
2021-09-10 17:44 ` Rodrigo Vivi [this message]
2021-09-13 10:57 ` [Intel-gfx] [PATCH 3/3] drm/i915: Enable runtime pm autosuspend by default Gupta, Anshuman
2021-09-13 18:49 ` Vivi, Rodrigo
2021-09-10 18:10 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/runtime_pm: Consolidate runtime_pm functions Patchwork
2021-09-10 18:39 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-10 19:56 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-09-10 22:06 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/runtime_pm: Consolidate runtime_pm functions (rev2) Patchwork
2021-09-10 22:34 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-11 0:25 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210910174447.289750-3-rodrigo.vivi@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=anshuman.gupta@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david.weinehall@linux.intel.com \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tilak.tangudu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox