Intel-GFX Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	intel-gfx@lists.freedesktop.org
Cc: kbuild-all@lists.01.org, dri-devel@lists.freedesktop.org,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Subject: [Intel-gfx] [PATCH] drm/i915: fix odd_ptr_err.cocci warnings
Date: Sat, 11 Sep 2021 09:14:23 +0800	[thread overview]
Message-ID: <20210911011423.GA20571@e8b8198c3ca8> (raw)
In-Reply-To: <20210910081942.1075038-1-maarten.lankhorst@linux.intel.com>

From: kernel test robot <lkp@intel.com>

drivers/gpu/drm/i915/display/intel_dpt.c:145:6-12: inconsistent IS_ERR and PTR_ERR on line 146.

 PTR_ERR should access the value just tested by IS_ERR

Semantic patch information:
 There can be false positives in the patch case, where it is the call to
 IS_ERR that is wrong.

Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci

CC: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---

url:    https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/drm-i915-Add-ww-context-to-intel_dpt_pin/20210910-162231
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
:::::: branch date: 17 hours ago
:::::: commit date: 17 hours ago

 intel_dpt.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/i915/display/intel_dpt.c
+++ b/drivers/gpu/drm/i915/display/intel_dpt.c
@@ -143,7 +143,7 @@ struct i915_vma *intel_dpt_pin(struct i9
 		i915_vma_unpin(vma);
 
 		if (IS_ERR(iomem)) {
-			err = PTR_ERR(vma);
+			err = PTR_ERR(iomem);
 			continue;
 		}
 

      parent reply	other threads:[~2021-09-11  1:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10  8:19 [Intel-gfx] [PATCH] drm/i915: Add ww context to intel_dpt_pin Maarten Lankhorst
2021-09-10  9:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork
2021-09-10 11:27 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2021-09-11  1:14 ` kernel test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210911011423.GA20571@e8b8198c3ca8 \
    --to=lkp@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kbuild-all@lists.01.org \
    --cc=maarten.lankhorst@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox