From: "Lisovskiy, Stanislav" <stanislav.lisovskiy@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, jani.saarinen@intel.com,
maarten.lankhorst@linux.intel.com, matthew.d.roper@intel.com
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Tile F plane format support
Date: Thu, 23 Sep 2021 13:44:11 +0300 [thread overview]
Message-ID: <20210923104411.GA5676@intel.com> (raw)
In-Reply-To: <87tuibbn7e.fsf@intel.com>
On Thu, Sep 23, 2021 at 01:28:21PM +0300, Jani Nikula wrote:
> On Thu, 23 Sep 2021, Stanislav Lisovskiy <stanislav.lisovskiy@intel.com> wrote:
> > @@ -1941,6 +1951,10 @@ static bool gen12_plane_format_mod_supported(struct drm_plane *_plane,
> > if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0))
> > return false;
> > break;
> > + case I915_FORMAT_MOD_F_TILED:
> > + if (!HAS_FTILE(dev_priv))
> > + return false;
> > + fallthrough;
> > default:
> > return false;
> > }
>
> Seems odd.
I agree, however this wasn't even added by me.
This patch got changed in ridiculous ways since last time,
I ever touched it.
Currently we have it internally exactly same way(wondering why)
Unfortunately didn't pay attention to this, was assuming
that if its r-bed and pushed - can trust it.
Stan
>
> BR,
> Jani.
>
>
> --
> Jani Nikula, Intel Open Source Graphics Center
next prev parent reply other threads:[~2021-09-23 10:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 8:48 [Intel-gfx] [PATCH] drm/i915: Tile F plane format support Stanislav Lisovskiy
2021-09-23 9:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2021-09-23 9:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-09-23 10:28 ` [Intel-gfx] [PATCH] " Jani Nikula
2021-09-23 10:44 ` Lisovskiy, Stanislav [this message]
2021-09-23 11:51 ` Lisovskiy, Stanislav
2021-09-23 11:03 ` [Intel-gfx] ✓ Fi.CI.IGT: success for " Patchwork
2021-09-23 15:49 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2021-09-23 16:19 ` Lisovskiy, Stanislav
2021-09-27 18:23 ` Matt Roper
2021-09-27 18:29 ` Ville Syrjälä
2021-09-28 5:24 ` Matt Roper
2021-09-28 12:49 ` Lisovskiy, Stanislav
2021-09-28 19:02 ` Ville Syrjälä
2021-09-28 20:36 ` Lisovskiy, Stanislav
2021-09-28 20:47 ` Ville Syrjälä
2021-09-29 6:15 ` Lisovskiy, Stanislav
-- strict thread matches above, loose matches on Subject: below --
2021-09-23 13:17 Stanislav Lisovskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210923104411.GA5676@intel.com \
--to=stanislav.lisovskiy@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=jani.saarinen@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox