From: Matthew Brost <matthew.brost@intel.com>
To: Thanneeru Srinivasulu <thanneeru.srinivasulu@intel.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
michal.wajdeczko@intel.com
Subject: Re: [Intel-gfx] [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures
Date: Mon, 11 Oct 2021 11:10:56 -0700 [thread overview]
Message-ID: <20211011181056.GA6310@jons-linux-dev-box> (raw)
In-Reply-To: <20211011152106.3424810-2-thanneeru.srinivasulu@intel.com>
On Mon, Oct 11, 2021 at 08:51:03PM +0530, Thanneeru Srinivasulu wrote:
> Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures.
>
> Signed-off-by: Thanneeru Srinivasulu <thanneeru.srinivasulu@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
> ---
> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> index 0a3504bc0b61..83764db0fd6d 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c
> @@ -191,8 +191,8 @@ static int ct_register_buffer(struct intel_guc_ct *ct, u32 type,
> err = guc_action_register_ct_buffer(ct_to_guc(ct), type,
> desc_addr, buff_addr, size);
> if (unlikely(err))
> - CT_ERROR(ct, "Failed to register %s buffer (%pe)\n",
> - guc_ct_buffer_type_to_str(type), ERR_PTR(err));
> + CT_PROBE_ERROR(ct, "Failed to register %s buffer (%pe)\n",
> + guc_ct_buffer_type_to_str(type), ERR_PTR(err));
> return err;
> }
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-10-11 18:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 15:21 [Intel-gfx] [PATCH 0/4] drm/i915/guc: Inject probe errors for MMIO send, CT send Thanneeru Srinivasulu
2021-10-11 15:21 ` [Intel-gfx] [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures Thanneeru Srinivasulu
2021-10-11 18:10 ` Matthew Brost [this message]
2021-10-12 16:16 ` Jani Nikula
2021-10-12 16:19 ` Jani Nikula
2021-10-12 16:43 ` Michal Wajdeczko
2021-10-11 15:21 ` [Intel-gfx] [PATCH 2/4] drm/i915/huc: Use i915_probe_error to report early HuC failures Thanneeru Srinivasulu
2021-10-11 18:13 ` Matthew Brost
2021-10-11 15:21 ` [Intel-gfx] [PATCH 3/4] drm/i915/guc: Inject probe errors for MMIO send Thanneeru Srinivasulu
2021-10-11 18:09 ` Matthew Brost
2021-10-11 15:21 ` [Intel-gfx] [PATCH 4/4] drm/i915/guc: Inject probe errors for CT send Thanneeru Srinivasulu
2021-10-11 18:00 ` Matthew Brost
2021-10-12 15:12 ` Michal Wajdeczko
2021-10-11 17:00 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Inject probe errors for MMIO send, " Patchwork
2021-10-11 20:33 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211011181056.GA6310@jons-linux-dev-box \
--to=matthew.brost@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.wajdeczko@intel.com \
--cc=thanneeru.srinivasulu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox