Re: [Intel-gfx] [PATCH 3/3] drm/i915: Initial introduction of vma resources

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2563 bytes --]

Hi "Thomas,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on drm-tip/drm-tip]
[cannot apply to drm-intel/for-linux-next drm-exynos/exynos-drm-next tegra-drm/drm/tegra/for-next airlied/drm-next v5.15-rc7 next-20211026]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Thomas-Hellstr-m/Prepare-error-capture-for-asynchronous-migration/20211026-150944
base:   git://anongit.freedesktop.org/drm/drm-tip drm-tip
config: x86_64-defconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/6c17f33fae142e4401d64d5399eb28e3c68f13a1
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Thomas-Hellstr-m/Prepare-error-capture-for-asynchronous-migration/20211026-150944
        git checkout 6c17f33fae142e4401d64d5399eb28e3c68f13a1
        # save the attached .config to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/i915/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/i915/i915_vma.c:1519: warning: expecting prototype for i915_vma_resource_hold(). Prototype was for i915_vma_resource_unhold() instead


vim +1519 drivers/gpu/drm/i915/i915_vma.c

  1508	
  1509	/**
  1510	 * i915_vma_resource_hold - Unhold the signaling of the vma resource unbind
  1511	 * fence.
  1512	 * @vma_res: The vma resource.
  1513	 * @lockdep_cookie: The lockdep cookie returned from i915_vma_resource_hold.
  1514	 *
  1515	 * The function may leave a dma_fence critical section.
  1516	 */
  1517	void i915_vma_resource_unhold(struct i915_vma_resource *vma_res,
  1518				      bool lockdep_cookie)
> 1519	{
  1520		dma_fence_end_signalling(lockdep_cookie);
  1521	
  1522		if (IS_ENABLED(CONFIG_PROVE_LOCKING)) {
  1523			unsigned long irq_flags;
  1524	
  1525			/* Inefficient open-coded might_lock_irqsave() */
  1526			spin_lock_irqsave(&vma_res->lock, irq_flags);
  1527			spin_unlock_irqrestore(&vma_res->lock, irq_flags);
  1528		}
  1529	
  1530		__i915_vma_resource_unhold(vma_res);
  1531	}
  1532	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29897 bytes --]